Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48742

PCT does not handle custom plugin groupIds when pulling plugin data from UC

XMLWordPrintable

      When I run PCT for a plugin with old Pipeline plugin dependency (e.g. job-restrictions plugin), I hit the following issue:

      [ERROR] Failed to execute goal on project job-restrictions: Could not resolve dependencies for project com.synopsys.arc.jenkinsci.plugins:job-restrictions:hpi:0.6: The following artifacts could not be resolved: org.jenkins-ci.plugins:workflow-step-api:jar:2.14, org.jenkins-ci.plugins:workflow-api:jar:2.24: Could not find artifact org.jenkins-ci.plugins:workflow-step-api:jar:2.14 in repo.jenkins-ci.org (https://repo.jenkins-ci.org/public/) -> [Help 1]

      It happens, because the group ID has been changed to "org.jenkins-ci.plugins.workflow". PCT should be ideally able to handle it somehow.

      Steps to reproduce:

      1. Run docker run --rm -v maven-repo:/root/.m2 -v $(pwd)/out:/pct/out -e ARTIFACT_ID=job-restrictions -e VERSION=job-restrictions-0.6 -i jenkins/pct
      2. Wait

          [JENKINS-48742] PCT does not handle custom plugin groupIds when pulling plugin data from UC

          Raul Arabaolaza added a comment -

          Maybe something similar to how the PCT handles splits could do the job, we can create some metadata map of old coordinates to new ones

          Raul Arabaolaza added a comment - Maybe something similar to how the PCT handles splits could do the job, we can create some metadata map of old coordinates to new ones

          Oleg Nenashev added a comment -

          It impacts the following recommended plugins:

          • git
          • github
          • junit
          • mailer

          The following plugins are not impacted:

          • ssh-slaves
          • matrix-auth

          Sounds like a blocking problem

          Oleg Nenashev added a comment - It impacts the following recommended plugins: git github junit mailer The following plugins are not impacted: ssh-slaves matrix-auth Sounds like a blocking problem

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          plugins-compat-tester/src/main/java/org/jenkins/tools/test/PluginCompatTester.java
          http://jenkins-ci.org/commit/plugin-compat-tester/8ebb1c8ad7cbf4e95ef87d67d26072e125fe2195
          Log:
          [FIXED JENKINS-48742] - Enable gathering of groupId info from Update Sites.

          Before this change PCT was collecting the info only from WAR files. In Jenkins 2.0 there is no information since the plugins are detached.
          Runs against plugins like Git or Mailer for the stock Jenkins core were just failing (workflow-api group ID has changed).

          After this change PCT will extract the data from Update Site, but it WILL NOT override the data extracted from the WAR file.
          So it will not cause regressions in WARs with bundled plugins. Confirmed it locally.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: plugins-compat-tester/src/main/java/org/jenkins/tools/test/PluginCompatTester.java http://jenkins-ci.org/commit/plugin-compat-tester/8ebb1c8ad7cbf4e95ef87d67d26072e125fe2195 Log: [FIXED JENKINS-48742] - Enable gathering of groupId info from Update Sites. Before this change PCT was collecting the info only from WAR files. In Jenkins 2.0 there is no information since the plugins are detached. Runs against plugins like Git or Mailer for the stock Jenkins core were just failing (workflow-api group ID has changed). After this change PCT will extract the data from Update Site, but it WILL NOT override the data extracted from the WAR file. So it will not cause regressions in WARs with bundled plugins. Confirmed it locally.

            oleg_nenashev Oleg Nenashev
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: