Unsigned Webhooks are always accepted

This issue is archived. You can view it, but you can't modify it. Learn more

XMLWordPrintable

    • Type: Bug
    • Resolution: Duplicate
    • Priority: Major
    • Component/s: github-plugin
    • Environment:

      When using a Shared Secret, Jenkins will accept webhook requests, which are not signed at all.

      • Github (Secret="123") --> Jenkins (Secret="123") 
      • Github (Secret="wrong") --> Jenkins (Secret="123") 
      • Github (Secret="") --> Jenkins (Secret="123")   This should not be "200 OK"

      The last example shows what happens when you omit the Shared Secret on the Github Webhook Configuration page but not in Jenkins. I expected Jenkins to reject the request.

            Assignee:
            Kirill Merkushev
            Reporter:
            Dominique Mattern
            Archiver:
            Jenkins Service Account

              Created:
              Updated:
              Resolved:
              Archived: