Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-4884

Added plugin mechanism for extending a build's display name

    XMLWordPrintable

    Details

    • Type: Patch
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Environment:
      Platform: All, OS: All
    • Similar Issues:

      Description

      This patch allows plugins to supply additional text to be appended to a Run's
      display name. Intended to be used by SCM plugins to display a branch name or
      revision number as part of the display name. This is achieved via a new
      interface DisplayNameAction for Run actions.

        Attachments

          Issue Links

            Activity

            Hide
            pcc pcc added a comment -

            Created an attachment (id=1021)
            [PATCH 1/2] Added plugin mechanism for extending a build's display name

            Show
            pcc pcc added a comment - Created an attachment (id=1021) [PATCH 1/2] Added plugin mechanism for extending a build's display name
            Hide
            pcc pcc added a comment -

            Created an attachment (id=1022)
            [PATCH 2/2] Changed all known Run.getNumber() references to Run.get

            {,Full}

            DisplayName() where appropriate

            Show
            pcc pcc added a comment - Created an attachment (id=1022) [PATCH 2/2] Changed all known Run.getNumber() references to Run.get {,Full} DisplayName() where appropriate
            Hide
            kohsuke Kohsuke Kawaguchi added a comment -

            Thank you for the patch.

            I'm not sure if the revision number from SCM is important enough that it should
            be displayed everywhere a build is referred to — I mean, normally isn't it a
            pretty cryptic meaningless token for most people anyway?

            I think a better change is to allow people to set the display name as text
            during a build, which should allow variable expansions like SCM revision numbers
            and other things. This is often referred to as "ability to set arbitrary build
            number", but what it really means is that people just want to control what
            Hudson shows as an ID of the build, and that doesn't have to be the same with
            what Hudson internally uses to refer to a build.

            Another lesson from that RFE is that people don't like random/meaningless
            numbers used as a build identifier, and to me this would only make it worse.

            So I feel we need to work on this a bit more before integrating this change.

            Show
            kohsuke Kohsuke Kawaguchi added a comment - Thank you for the patch. I'm not sure if the revision number from SCM is important enough that it should be displayed everywhere a build is referred to — I mean, normally isn't it a pretty cryptic meaningless token for most people anyway? I think a better change is to allow people to set the display name as text during a build, which should allow variable expansions like SCM revision numbers and other things. This is often referred to as "ability to set arbitrary build number", but what it really means is that people just want to control what Hudson shows as an ID of the build, and that doesn't have to be the same with what Hudson internally uses to refer to a build. Another lesson from that RFE is that people don't like random/meaningless numbers used as a build identifier, and to me this would only make it worse. So I feel we need to work on this a bit more before integrating this change.
            Hide
            kohsuke Kohsuke Kawaguchi added a comment -

            Issue #53 appears to cover the ability to set a build number.

            Show
            kohsuke Kohsuke Kawaguchi added a comment - Issue #53 appears to cover the ability to set a build number.
            Hide
            kohsuke Kohsuke Kawaguchi added a comment -

            In 1.390, the display name of a build is modifiable.
            Committed in ad27bab4e74178aa86a973acb20d6c0747aad894

            Show
            kohsuke Kohsuke Kawaguchi added a comment - In 1.390, the display name of a build is modifiable. Committed in ad27bab4e74178aa86a973acb20d6c0747aad894

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              pcc pcc
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: