Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48954

GitHub API plugin should whitelist Model classes of GitHub API

XMLWordPrintable

      In some cases plugin classes are being used for serialization over the channel or storing data on the disk. E.g. JENKINS-48950 and JENKINS-48952. It is probably safe to just allow it for model classes.

          [JENKINS-48954] GitHub API plugin should whitelist Model classes of GitHub API

          Oleg Nenashev added a comment -

          I do not think that whitelisting of entire library is plausible since there are potentially dangerous classes

          Oleg Nenashev added a comment - I do not think that whitelisting of entire library is plausible since there are potentially dangerous classes

          Oleg Nenashev added a comment -

          Pending patch

          Oleg Nenashev added a comment - Pending patch

          Jesse Glick added a comment -

          I am not convinced this is even desirable.

          Jesse Glick added a comment - I am not convinced this is even desirable.

          Oleg Nenashev added a comment -

          I am working on workarounds in GHPRB for now, but will put patches just in case

          Oleg Nenashev added a comment - I am working on workarounds in GHPRB for now, but will put patches just in case

          Jesse Glick added a comment -

          From what I can see so far, no patched to github-api are necessary or desirable. We just need to fix ghprb.

          Jesse Glick added a comment - From what I can see so far, no patched to github-api are necessary or desirable. We just need to fix ghprb .

          Oleg Nenashev added a comment -

          I agree

          Oleg Nenashev added a comment - I agree

            oleg_nenashev Oleg Nenashev
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: