[JENKINS-49006] ConcurrentModificationException in getThrottledPipelineRunsForCategory - Jenkins Jira

Details

Type: Bug
Status: Resolved (View Workflow)
Priority: Major
Resolution: Fixed
Component/s: throttle-concurrent-builds-plugin
Labels:
None
Environment:

Hide
Ubuntu 16.04.3 LTS
Jenkins 2.89.2
TCB 2.0.1
$ uname -a
Linux fwee-test-station 4.4.0-104-generic #127-Ubuntu SMP Mon Dec 11 12:16:42 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
$ java -version
openjdk version "1.8.0_151"
OpenJDK Runtime Environment (build 1.8.0_151-8u151-b12-0ubuntu0.16.04.2-b12)
OpenJDK 64-Bit Server VM (build 25.151-b12, mixed mode)

Show
Ubuntu 16.04.3 LTS Jenkins 2.89.2 TCB 2.0.1 $ uname -a Linux fwee-test-station 4.4.0-104-generic #127-Ubuntu SMP Mon Dec 11 12:16:42 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux $ java -version openjdk version "1.8.0_151" OpenJDK Runtime Environment (build 1.8.0_151-8u151-b12-0ubuntu0.16.04.2-b12) OpenJDK 64-Bit Server VM (build 25.151-b12, mixed mode)

Similar Issues:

Show
Released As:
2.0.2

Description

I started two builds of a pipeline job which uses the throttle step against a category. The category is configured to permit a maximum of one build at a time. The second build hit the throttled node step, waited for somewhere around 30–40 minutes, and then started executing anyway, despite the first build not having exited the throttled node step yet. I found this in my Jenkins log:

SEVERE: Timer task hudson.model.Queue$MaintainTask@63d577c failed
java.util.ConcurrentModificationException
	at java.util.TreeMap$PrivateEntryIterator.nextEntry(TreeMap.java:1211)
	at java.util.TreeMap$EntryIterator.next(TreeMap.java:1247)
	at java.util.TreeMap$EntryIterator.next(TreeMap.java:1242)
	at hudson.plugins.throttleconcurrents.ThrottleJobProperty.getThrottledPipelineRunsForCategory(ThrottleJobProperty.java:316)
	at hudson.plugins.throttleconcurrents.ThrottleQueueTaskDispatcher.throttleCheckForCategoriesOnNode(ThrottleQueueTaskDispatcher.java:132)
	at hudson.plugins.throttleconcurrents.ThrottleQueueTaskDispatcher.canTakeImpl(ThrottleQueueTaskDispatcher.java:101)
	at hudson.plugins.throttleconcurrents.ThrottleQueueTaskDispatcher.canTake(ThrottleQueueTaskDispatcher.java:55)
	at hudson.model.queue.QueueTaskDispatcher.canTake(QueueTaskDispatcher.java:102)
	at hudson.model.Queue$JobOffer.getCauseOfBlockage(Queue.java:273)
	at hudson.model.Queue.maintain(Queue.java:1597)
	at hudson.model.Queue$MaintainTask.doRun(Queue.java:2833)
	at hudson.triggers.SafeTimerTask.run(SafeTimerTask.java:51)
	at jenkins.security.ImpersonatingScheduledExecutorService$1.run(ImpersonatingScheduledExecutorService.java:58)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

Attachments

Issue Links

links to

jenkinsci/throttle-concurrent-builds-plugin#58

Activity

Ascending order - Click to sort in descending order

View 4 older comments

Basil Crow added a comment - 2020-02-05 23:19

haw777, sk_nano, and medianick, this issue should be resolved on master and I am preparing a release of Throttle Concurrent Builds with the fix for this issue. There is an incremental build available here. Are any of you interested in testing this incremental build before I do an official release?

Basil Crow added a comment - 2020-02-05 23:19 haw777 , sk_nano , and medianick , this issue should be resolved on master and I am preparing a release of Throttle Concurrent Builds with the fix for this issue. There is an incremental build available here . Are any of you interested in testing this incremental build before I do an official release?

Christopher Head added a comment - 2020-02-06 05:05

Sorry, I can’t test it. I switched to Lockable Resources a long time ago, initially to fix this bug but now we use some other features too.

Christopher Head added a comment - 2020-02-06 05:05 Sorry, I can’t test it. I switched to Lockable Resources a long time ago, initially to fix this bug but now we use some other features too.

Nick Jones added a comment - 2020-02-06 19:57 - edited

basil Yes, I'd be happy to get it tested on our side. We too had switched to Lockable Resources (like haw777), though in our case was a bit of a kludge (to achieve throttling using a predefined quantity of resources that share the same category), so I'd be happy to retry with this new incremental build on our test Jenkins system. I'll grab it and post back here with my findings.

Nick Jones added a comment - 2020-02-06 19:57 - edited basil Yes, I'd be happy to get it tested on our side. We too had switched to Lockable Resources (like haw777 ), though in our case was a bit of a kludge (to achieve throttling using a predefined quantity of resources that share the same category), so I'd be happy to retry with this new incremental build on our test Jenkins system. I'll grab it and post back here with my findings.

Basil Crow added a comment - 2020-02-13 19:19

Fixed in jenkinsci/throttle-concurrent-builds-plugin#58.

Basil Crow added a comment - 2020-02-13 19:19 Fixed in jenkinsci/throttle-concurrent-builds-plugin#58 .

Basil Crow added a comment - 2020-02-19 21:17

Released in Throttle Concurrent Builds 2.0.2.

Basil Crow added a comment - 2020-02-19 21:17 Released in Throttle Concurrent Builds 2.0.2 .