Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-49026

Plugins are not installed in right order in case of optional dependency

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Example from failing ATH test:

      checkstyle plugin has optional dependency on dashboard view plugin. In this case are both plugin required in the same time from UI. According to right order of dependency, jenkins should install dashboard view first (since checkstyle is dependent on it). In case that dashboard is installed before checkstyle, extensions points in checkstyle plugin which are optional is not loaded and checkstyle dashboard view portlets are not available.

      Everything is loaded properly when Jenkins is restarted.

      I believe this can be fixed by including optional dependencies into process which determine installation order for plugins. 

      There several tests in ATH which fail because of it:

      plugins.CheckStylePluginTest.should_show_warnings_in_folder

      plugins.CheckStylePluginTest.should_show_warning_totals_in_dashboard_portlet_with_link_to_results

      plugins.AnalysisCollectorPluginTest.should_aggregate_warnings_in_dashboard_portlet

      plugins.AnalysisCollectorPluginTest.should_show_warnings_in_folder

      plugins.AnalysisCollectorPluginTest.should_show_warning_totals_in_dashboard_portlet_with_link_to_result

      plugins.AnalysisCollectorPluginTest.should_open_links_in_folder_dashboard_and_nested_views

      It is not so easy to catch it because other plugins or other dependencies can influence order. But in with these plugins alone and jenkins-2.89.3, it is easy to reproduce:

      dashboard-view 2.9.11

      analysis-core 1.93

      checkstyle 3.49

       

      I load screen shot of ath tests for documentation.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Lucie Votypkova
            Path:
            src/test/java/plugins/AbstractAnalysisTest.java
            src/test/java/plugins/AnalysisCollectorPluginTest.java
            src/test/java/plugins/CheckStylePluginTest.java
            src/test/java/plugins/WarningsPluginTest.java
            http://jenkins-ci.org/commit/acceptance-test-harness/29b5426e57bb3b7167ecb6e98f01b96d5e91ebcc
            Log:
            Avoid JENKINS-49026.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Lucie Votypkova Path: src/test/java/plugins/AbstractAnalysisTest.java src/test/java/plugins/AnalysisCollectorPluginTest.java src/test/java/plugins/CheckStylePluginTest.java src/test/java/plugins/WarningsPluginTest.java http://jenkins-ci.org/commit/acceptance-test-harness/29b5426e57bb3b7167ecb6e98f01b96d5e91ebcc Log: Avoid JENKINS-49026 .
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oliver Gondža
            Path:
            src/test/java/plugins/AbstractAnalysisTest.java
            src/test/java/plugins/AnalysisCollectorPluginTest.java
            src/test/java/plugins/CheckStylePluginTest.java
            src/test/java/plugins/WarningsPluginTest.java
            http://jenkins-ci.org/commit/acceptance-test-harness/2a6b4ce0b06abc0e547f91e447839cb1e0766325
            Log:
            Merge pull request #413 from lvotypko/JENKINS-49026

            Avoid JENKINS-49026.

            Compare: https://github.com/jenkinsci/acceptance-test-harness/compare/b452448d99e6...2a6b4ce0b06a

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: src/test/java/plugins/AbstractAnalysisTest.java src/test/java/plugins/AnalysisCollectorPluginTest.java src/test/java/plugins/CheckStylePluginTest.java src/test/java/plugins/WarningsPluginTest.java http://jenkins-ci.org/commit/acceptance-test-harness/2a6b4ce0b06abc0e547f91e447839cb1e0766325 Log: Merge pull request #413 from lvotypko/ JENKINS-49026 Avoid JENKINS-49026 . Compare: https://github.com/jenkinsci/acceptance-test-harness/compare/b452448d99e6...2a6b4ce0b06a

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              lvotypkova Lucie Votypkova
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated: