Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-49381

Need to update github-api on github-plugin

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Github Plugin is using github-api 1.90:

      https://github.com/jenkinsci/github-plugin/blob/v1.29.0/pom.xml

      <dependency>
      <groupId>org.jenkins-ci.plugins</groupId>
      <artifactId>github-api</artifactId>
      <version>1.90</version>
      </dependency>

      We need to bump it, since it's not dealing with deprecated REST API, like "REQUEST_CHANGES", which is fixed on 1.92
      https://github.com/kohsuke/github-api/commit/acbf286e59d92592038e9c0cf56dd91509d93446#diff-4d87023646146a3a508fbb53c7e45149R5

      + * Current state of {@link GHPullRequestReview}
      + */
       public enum GHPullRequestReviewState {
       PENDING,
       APPROVED,
       CHANGES_REQUESTED,
      + /**
      + * @deprecated
      + * This was the thing when this API was in preview, but it changed when it became public.
      + * Use {@link #CHANGES_REQUESTED}. Left here for compatibility.
      + */
      + REQUEST_CHANGES,
       COMMENTED,
      - DISMISSED
      + DISMISSED;

       

        Attachments

          Activity

          Hide
          integer Kanstantsin Shautsou added a comment -

          Github plugin is requiring minimal github-api plugin version. That mean that you can install any newer api-plugin version when issue is in api.

          Show
          integer Kanstantsin Shautsou added a comment - Github plugin is requiring minimal github-api plugin version. That mean that you can install any newer api-plugin version when issue is in api.
          Hide
          tgomes Thiago Gomes added a comment -

          We would need this PR to be merged:
          https://github.com/jenkinsci/github-api-plugin/pull/19

          Show
          tgomes Thiago Gomes added a comment - We would need this PR to be merged: https://github.com/jenkinsci/github-api-plugin/pull/19

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            ramonmedeiros Ramon Medeiros
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated: