Details
-
New Feature
-
Status: Open (View Workflow)
-
Minor
-
Resolution: Unresolved
-
Ubuntu 16.04
Jenkins ver. 2.46.2 LTS
promoted builds plugin v2.28.1
Description
I have selected "Promote immediately once the build is complete based on build parameters" with:
Parameter Name: ${AUTO_APPROVE}
Parameter Value: true
or
Parameter Name: AUTO_APPROVE
Parameter Value: true
In the build,
when Boolean paramter AUTO_APPROVE is set to true,
the promotion job doesn't start.
Attachments
Activity
Attached build.xml
build-97 is a rebuild from build#96.
build-97 is a fresh clean build.
Both have the same issue.
Rick Liu
added a comment - - edited Attached build.xml
build-97 is a rebuild from build#96.
build-97 is a fresh clean build.
Both have the same issue. Hi Oleg~
After some job config cleanup and retry,
now I'm able to see:
*******************
Met Qualification
Automatically promoted immediately after the build because parameter was matched
*******************
Unmet Qualification
Manual Approval
*******************
Refer to the screensot attachment.
I'd think the issue right now it's the code is using boolean 'AND' to chain-up the criterias.
But it should use boolean 'OR' to meet the meaning of "Promote immediately once the build is complete based on build parameters".
Rick Liu
added a comment - - edited Hi Oleg~
After some job config cleanup and retry,
now I'm able to see:
*******************
Met Qualification
Automatically promoted immediately after the build because parameter was matched
*******************
Unmet Qualification
Manual Approval
*******************
Refer to the screensot attachment.
I'd think the issue right now it's the code is using boolean ' AND ' to chain-up the criterias.
But it should use boolean ' OR ' to meet the meaning of " Promote immediately once the build is complete based on build parameters ".
The plugin behaves as documented in the code: https://github.com/jenkinsci/promoted-builds-plugin/blob/f7589c3c3e76f357393c6431a6412f2bc1e55ee7/src/main/java/hudson/plugins/promoted_builds/PromotionProcess.java#L73 .
I agree it needs to be documented in https://github.com/jenkinsci/promoted-builds-plugin/blob/master/src/main/resources/hudson/plugins/promoted_builds/PromotionProcess/process-config.jelly and in README, but it is not a defect
Rick Liu
added a comment - ok I agree with you ~
In addition to document improvement,
maybe add a new feature to choose AND or OR for promote conditions.
Rick Liu
added a comment - ok I agree with you ~
In addition to document improvement,
maybe add a new feature to choose AND or OR for promote conditions. Rick Liu
added a comment - Pull request prepared:
https://github.com/jenkinsci/promoted-builds-plugin/pull/115
Rick Liu
added a comment - Pull request prepared:
https://github.com/jenkinsci/promoted-builds-plugin/pull/115 
t should work well according to the code. Could you please provide full build.xml file?