Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-497

Make use of -z3 compression for CVS optional

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: cvs-plugin
    • Labels:
      None
    • Environment:
      Platform: All, OS: All
    • Similar Issues:

      Description

      Would it be possible to make use of compression for CVS optional?
      It should be as simple as adding checkbox to the project configuration page and
      modifying compression() method in hudson.scm.CVSSCM.java
      It would allow to switch of compression where it can't be used for various reasons.

      private String compression()

      { // CVS 1.11.22 manual: // If the access method is omitted, then if the repository starts with // `/', then `:local:' is assumed. If it does not start with `/' then // either `:ext:' or `:server:' is assumed. boolean local = cvsroot.startsWith("/") || cvsroot.startsWith(":local:") || cvsroot.startsWith(":fork:"); // For local access, compression is senseless. For remote, use z3: // http://root.cern.ch/root/CVS.html#checkout return local ? "-z0" : "-z3"; }

      Thanks.

        Attachments

          Activity

          Hide
          kohsuke Kohsuke Kawaguchi added a comment -

          I'm curious why you'd want to do that?

          Show
          kohsuke Kohsuke Kawaguchi added a comment - I'm curious why you'd want to do that?
          Hide
          jglick Jesse Glick added a comment -

          I'm also curious about that. When can't you use compression?

          Show
          jglick Jesse Glick added a comment - I'm also curious about that. When can't you use compression?
          Hide
          rah003 rah003 added a comment -

          Since I‘ve got cvs client that does not understend z3 compression and no chance
          to upgrade to newer one. Also the only part of the build process that is
          affected by compression is CVS polling. Rest of the build process is OK.

          Show
          rah003 rah003 added a comment - Since I‘ve got cvs client that does not understend z3 compression and no chance to upgrade to newer one. Also the only part of the build process that is affected by compression is CVS polling. Rest of the build process is OK.
          Hide
          jglick Jesse Glick added a comment -

          Which CVS client does not support compression?

          Show
          jglick Jesse Glick added a comment - Which CVS client does not support compression?
          Hide
          rah003 rah003 added a comment -

          1.11.1p1 fails with "unknown compression method".
          Just as a matter of fact, it works even the other way around. I have a firewall
          between one of the build servers running Hudson and cvs repository. I have
          tunnel through the firewall which is local to the build server. Therefore from
          hudson I specify repository as local (which makes hudson to switch off
          compression), but in fact it is remote. So you may want to allow use of
          compression even if repository appear to be local.
          But if you think letting user to have a control over this option is not good,
          then just close the issue. I can live without it, although it would be more
          convenient to be able to specify what I want.

          Show
          rah003 rah003 added a comment - 1.11.1p1 fails with "unknown compression method". Just as a matter of fact, it works even the other way around. I have a firewall between one of the build servers running Hudson and cvs repository. I have tunnel through the firewall which is local to the build server. Therefore from hudson I specify repository as local (which makes hudson to switch off compression), but in fact it is remote. So you may want to allow use of compression even if repository appear to be local. But if you think letting user to have a control over this option is not good, then just close the issue. I can live without it, although it would be more convenient to be able to specify what I want.
          Hide
          kohsuke Kohsuke Kawaguchi added a comment -

          The same RFE was made in issue #385, so it must be that this problem is more
          common that I thought.

          Implementing this for 1.104.

          Show
          kohsuke Kohsuke Kawaguchi added a comment - The same RFE was made in issue #385, so it must be that this problem is more common that I thought. Implementing this for 1.104.
          Hide
          kohsuke Kohsuke Kawaguchi added a comment -

          Implemented in 1.104. Look for the "advanced" button in the global CVS
          configuration.

          Show
          kohsuke Kohsuke Kawaguchi added a comment - Implemented in 1.104. Look for the "advanced" button in the global CVS configuration.

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            rah003 rah003
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: