Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-49795

Bad serialization of ParametersAction.parameterDefinitionNames

      Splitting out of JENKINS-49573 at oleg_nenashev's request. See that issue for discussion.

          [JENKINS-49795] Bad serialization of ParametersAction.parameterDefinitionNames

          Oleg Nenashev added a comment -

          The fix has been integrated towards 2.110

          Oleg Nenashev added a comment - The fix has been integrated towards 2.110

          Oleg Nenashev added a comment -

          For the record, this change also adds diagnostics messaging for things considered as improper serialization (Anonymous classes & So on): https://issues.jenkins-ci.org/browse/JENKINS-49573?focusedCommentId=331183&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-331183 . IMHO this messaging part should not be backported IMHO (or it should be disabled by default at least). CC olivergondza

          Oleg Nenashev added a comment - For the record, this change also adds diagnostics messaging for things considered as improper serialization (Anonymous classes & So on): https://issues.jenkins-ci.org/browse/JENKINS-49573?focusedCommentId=331183&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-331183 . IMHO this messaging part should not be backported IMHO (or it should be disabled by default at least). CC olivergondza

          oleg_nenashev, what is the reason for not backporting the diagnostics part?

          Oliver Gondža added a comment - oleg_nenashev , what is the reason for not backporting the diagnostics part?

          Oleg Nenashev added a comment -

          olivergondza

          • Remoting serializes lots of Anonymous classes by design, there are many anonymous classes for Remoting in the core. For each classes you will get at least one warning in the log
          • We have already received first reports: JENKINS-49976 and JENKINS-49977 (XStream ones though)

          I would suggest to not have warnings in LTS, because there is no short-term plan to fix the Remoting part

          Oleg Nenashev added a comment - olivergondza Remoting serializes lots of Anonymous classes by design, there are many anonymous classes for Remoting in the core. For each classes you will get at least one warning in the log We have already received first reports: JENKINS-49976 and JENKINS-49977 (XStream ones though) I would suggest to not have warnings in LTS, because there is no short-term plan to fix the Remoting part

          Oleg Nenashev added a comment -

          I have created a JENKINS-49987 EPIC for changes in the Core

          Oleg Nenashev added a comment - I have created a JENKINS-49987 EPIC for changes in the Core

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/jenkins/security/ClassFilterImpl.java
          http://jenkins-ci.org/commit/jenkins/48c95f5aee999a7fbf6d30f3a1e92eabf3723a02
          Log:
          s/JENKINS-49573/JENKINS-49795/g in messages.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/jenkins/security/ClassFilterImpl.java http://jenkins-ci.org/commit/jenkins/48c95f5aee999a7fbf6d30f3a1e92eabf3723a02 Log: s/ JENKINS-49573 / JENKINS-49795 /g in messages.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/jenkins/security/ClassFilterImpl.java
          http://jenkins-ci.org/commit/jenkins/93b951046f95275f1a7d55e2e96392476b5a7a24
          Log:
          Merge pull request #3332 from jglick/message-JENKINS-49795

          s/JENKINS-49573/JENKINS-49795/g in messages

          Compare: https://github.com/jenkinsci/jenkins/compare/c5e96fb6180b...93b951046f95

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/jenkins/security/ClassFilterImpl.java http://jenkins-ci.org/commit/jenkins/93b951046f95275f1a7d55e2e96392476b5a7a24 Log: Merge pull request #3332 from jglick/message- JENKINS-49795 s/ JENKINS-49573 / JENKINS-49795 /g in messages Compare: https://github.com/jenkinsci/jenkins/compare/c5e96fb6180b...93b951046f95

          oleg_nenashev, to me it seems it should not be an lts-candidate than. jglick, do you agree?

          Oliver Gondža added a comment - oleg_nenashev , to me it seems it should not be an lts-candidate than. jglick , do you agree?

          Oleg Nenashev added a comment -

          olivergondza I am definitely fine with backporting a bugfix, but I vote to NOT backport the "make sure this kind of mistake produces a warning in the future" part. It causes much spam, at least until we fix the issues in the core and most popular plugins

          Oleg Nenashev added a comment - olivergondza I am definitely fine with backporting a bugfix, but I vote to NOT backport the "make sure this kind of mistake produces a warning in the future" part. It causes much spam, at least until we fix the issues in the core and most popular plugins

          Code changed in jenkins
          User: Daniel Beck
          Path:
          content/_data/changelogs/lts.yml
          http://jenkins-ci.org/commit/jenkins.io/30d3398d9e8183dc78d522e0643e6a1b1d491de2
          Log:
          Add JENKINS-49795

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: content/_data/changelogs/lts.yml http://jenkins-ci.org/commit/jenkins.io/30d3398d9e8183dc78d522e0643e6a1b1d491de2 Log: Add JENKINS-49795

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: