Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-49839

GlobalConfiguration: Correct @Nonnull / @CheckForNull for get()

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      Lots of GlobalConfiguration implementation does not respect the annotations for their #get() method. Also their usages inside core are not checking for nullability.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Wadeck Follonier
          Path:
          core/src/main/java/hudson/ExtensionList.java
          core/src/main/java/hudson/model/Descriptor.java
          core/src/main/java/hudson/model/Run.java
          core/src/main/java/hudson/security/csrf/GlobalCrumbIssuerConfiguration.java
          core/src/main/java/hudson/tools/ToolDescriptor.java
          core/src/main/java/hudson/views/GlobalDefaultViewConfiguration.java
          core/src/main/java/hudson/views/MyViewsTabBar.java
          core/src/main/java/hudson/views/ViewsTabBar.java
          core/src/main/java/jenkins/CLI.java
          core/src/main/java/jenkins/model/ArtifactManagerConfiguration.java
          core/src/main/java/jenkins/model/DownloadSettings.java
          core/src/main/java/jenkins/model/GlobalCloudConfiguration.java
          core/src/main/java/jenkins/model/GlobalConfiguration.java
          core/src/main/java/jenkins/model/GlobalConfigurationCategory.java
          core/src/main/java/jenkins/model/GlobalNodePropertiesConfiguration.java
          core/src/main/java/jenkins/model/GlobalPluginConfiguration.java
          core/src/main/java/jenkins/model/GlobalProjectNamingStrategyConfiguration.java
          core/src/main/java/jenkins/model/GlobalQuietPeriodConfiguration.java
          core/src/main/java/jenkins/model/GlobalSCMRetryCountConfiguration.java
          core/src/main/java/jenkins/model/Jenkins.java
          core/src/main/java/jenkins/model/JenkinsLocationConfiguration.java
          core/src/main/java/jenkins/model/MasterBuildConfiguration.java
          core/src/main/java/jenkins/mvn/GlobalMavenConfig.java
          core/src/main/java/jenkins/security/QueueItemAuthenticatorConfiguration.java
          core/src/main/java/jenkins/security/UpdateSiteWarningsConfiguration.java
          core/src/main/java/jenkins/security/s2m/MasterKillSwitchConfiguration.java
          core/src/main/java/jenkins/tools/ToolConfigurationCategory.java
          http://jenkins-ci.org/commit/jenkins/79ec930a8ef4f12d2f2574c50c2f42272e5c75fb
          Log:
          JENKINS-49839 correct annotation check (#3321)

          • also correct a bad annotation in Run
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Wadeck Follonier Path: core/src/main/java/hudson/ExtensionList.java core/src/main/java/hudson/model/Descriptor.java core/src/main/java/hudson/model/Run.java core/src/main/java/hudson/security/csrf/GlobalCrumbIssuerConfiguration.java core/src/main/java/hudson/tools/ToolDescriptor.java core/src/main/java/hudson/views/GlobalDefaultViewConfiguration.java core/src/main/java/hudson/views/MyViewsTabBar.java core/src/main/java/hudson/views/ViewsTabBar.java core/src/main/java/jenkins/CLI.java core/src/main/java/jenkins/model/ArtifactManagerConfiguration.java core/src/main/java/jenkins/model/DownloadSettings.java core/src/main/java/jenkins/model/GlobalCloudConfiguration.java core/src/main/java/jenkins/model/GlobalConfiguration.java core/src/main/java/jenkins/model/GlobalConfigurationCategory.java core/src/main/java/jenkins/model/GlobalNodePropertiesConfiguration.java core/src/main/java/jenkins/model/GlobalPluginConfiguration.java core/src/main/java/jenkins/model/GlobalProjectNamingStrategyConfiguration.java core/src/main/java/jenkins/model/GlobalQuietPeriodConfiguration.java core/src/main/java/jenkins/model/GlobalSCMRetryCountConfiguration.java core/src/main/java/jenkins/model/Jenkins.java core/src/main/java/jenkins/model/JenkinsLocationConfiguration.java core/src/main/java/jenkins/model/MasterBuildConfiguration.java core/src/main/java/jenkins/mvn/GlobalMavenConfig.java core/src/main/java/jenkins/security/QueueItemAuthenticatorConfiguration.java core/src/main/java/jenkins/security/UpdateSiteWarningsConfiguration.java core/src/main/java/jenkins/security/s2m/MasterKillSwitchConfiguration.java core/src/main/java/jenkins/tools/ToolConfigurationCategory.java http://jenkins-ci.org/commit/jenkins/79ec930a8ef4f12d2f2574c50c2f42272e5c75fb Log: JENKINS-49839 correct annotation check (#3321) also correct a bad annotation in Run
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          some bits are merged, we can do the rest in future iterations

           

          Show
          oleg_nenashev Oleg Nenashev added a comment - some bits are merged, we can do the rest in future iterations  

            People

            Assignee:
            wfollonier Wadeck Follonier
            Reporter:
            wfollonier Wadeck Follonier
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: