Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-50211

Reject connections from agents with unsupported Remoting versions

    • 2.343

      It is a follow-up to JENKINS-48766. That story adds warnings for unsupported agent versions, but it actually does not reject them. It would be useful to have such feature in the core or in Version Column Plugin. Core is preferable though this feature may be detached to a plugin later as a part of JENKINS-44100.

      Acceptance criteria:

      • There is a Global Configuration entry for Remoting. An existing section for Remoting protocols may be used
      • There is a checkbox in the configuration, which turns on rejection of unsupported versions
      • SlaveComputer#setChannel() checks the option status. Depending on it, it may either accept or reject the connection
      • Nice2have: Automatic test which confirms that the flag survives restarts
      • Nice2have: Automatic test which picks unsupported version of Remoting and confirms that it cannot connect. See examples in https://github.com/jenkinsci/jenkins/blob/master/test/src/test/java/jenkins/slaves/OldRemotingAgentTest.java

          [JENKINS-50211] Reject connections from agents with unsupported Remoting versions

          Oleg Nenashev created issue -
          Oleg Nenashev made changes -
          Link New: This issue relates to JENKINS-48766 [ JENKINS-48766 ]
          Oleg Nenashev made changes -
          Link New: This issue relates to JENKINS-44100 [ JENKINS-44100 ]
          Oleg Nenashev made changes -
          Description Original: It is a follow-up to JENKINS-48766. That story adds warnings for unsupported agent versions, but it actually does not reject them. It would be useful to have such feature in the core or in Version Column Plugin. Core is preferable though this feature may be detached to a plugin later as a part of JENKINS-44100.

          Acceptance criteria:

          * There is a Global Configuration entry for Remoting. An existing section for Remoting protocols may be used
          * There is a checkbox in the configuration, which turns on rejection of unsupported versions
          * SlaveComputer#setChannel() checks the option status. Depending on it, it may either accept or reject the connection

          New: It is a follow-up to JENKINS-48766. That story adds warnings for unsupported agent versions, but it actually does not reject them. It would be useful to have such feature in the core or in Version Column Plugin. Core is preferable though this feature may be detached to a plugin later as a part of JENKINS-44100.

          Acceptance criteria:

          * There is a Global Configuration entry for Remoting. An existing section for Remoting protocols may be used
          * There is a checkbox in the configuration, which turns on rejection of unsupported versions
          * SlaveComputer#setChannel() checks the option status. Depending on it, it may either accept or reject the connection
          * Nice2have: Automatic test which confirms that the flag survives restarts
          * Nice2have: Automatic test which picks unsupported version of Remoting and confirms that it cannot connect

          Oleg Nenashev made changes -
          Issue Type Original: Bug [ 1 ] New: New Feature [ 2 ]
          Oleg Nenashev made changes -
          Priority Original: Minor [ 4 ] New: Major [ 3 ]
          Oleg Nenashev made changes -
          Description Original: It is a follow-up to JENKINS-48766. That story adds warnings for unsupported agent versions, but it actually does not reject them. It would be useful to have such feature in the core or in Version Column Plugin. Core is preferable though this feature may be detached to a plugin later as a part of JENKINS-44100.

          Acceptance criteria:

          * There is a Global Configuration entry for Remoting. An existing section for Remoting protocols may be used
          * There is a checkbox in the configuration, which turns on rejection of unsupported versions
          * SlaveComputer#setChannel() checks the option status. Depending on it, it may either accept or reject the connection
          * Nice2have: Automatic test which confirms that the flag survives restarts
          * Nice2have: Automatic test which picks unsupported version of Remoting and confirms that it cannot connect

          New: It is a follow-up to JENKINS-48766. That story adds warnings for unsupported agent versions, but it actually does not reject them. It would be useful to have such feature in the core or in Version Column Plugin. Core is preferable though this feature may be detached to a plugin later as a part of JENKINS-44100.

          Acceptance criteria:

          * There is a Global Configuration entry for Remoting. An existing section for Remoting protocols may be used
          * There is a checkbox in the configuration, which turns on rejection of unsupported versions
          * SlaveComputer#setChannel() checks the option status. Depending on it, it may either accept or reject the connection
          * Nice2have: Automatic test which confirms that the flag survives restarts
          * Nice2have: Automatic test which picks unsupported version of Remoting and confirms that it cannot connect. See examples in https://github.com/jenkinsci/jenkins/blob/master/test/src/test/java/jenkins/slaves/OldRemotingAgentTest.java

          Abhishek Gautam made changes -
          Assignee New: Abhishek Gautam [ gautamabhishek46 ]
          Oleg Nenashev made changes -
          Labels Original: remoting New: newbie-friendly remoting
          Oleg Nenashev made changes -
          Remote Link New: This issue links to "Stalled PR - 3353 (Web Link)" [ 22314 ]
          Oleg Nenashev made changes -
          Assignee Original: Abhishek Gautam [ gautamabhishek46 ]

            stellargo stellargo
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: