Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-50315

Editable mode not offering selection once a selection has been made

      The editable mode that now offers dynamic filtering as you type in the field has a user unfriendly issue.

      The dynamic filtering of the combo box items as you type is okay. But once an item has been selected, the "filtering state" of the combo box stays, resulting in having only the selected item displayed in the combo box. All items of the combo box should be displayed once a valid selection has been made, otherwise you need to clear out the field in order to have all your items displayed and selectable again.

      This is especially obvious when, for instance, you configure your Extensible Choice as Editable, with the Default Choice as the Top Most Value. The result is that your combo box is shown with the top most item, but with absolutely no way to make a selection, as if the combo box only had the top most item available. It took me quite a few minutes to realize that I had to clear the field, which is not the most user friendly or obvious way of interacting with the combo box.

          [JENKINS-50315] Editable mode not offering selection once a selection has been made

          ikedam added a comment -

          ikedam added a comment - https://github.com/jenkinsci/extensible-choice-parameter-plugin/pull/38

          ikedam added a comment -

          I plan to provide an option to switch the behavior (see the pull request for details),
          and make a new release in the next weekend.

          ikedam added a comment - I plan to provide an option to switch the behavior (see the pull request for details), and make a new release in the next weekend.

          Code changed in jenkins
          User: ikedam
          Path:
          src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition.java
          src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/config.jelly
          src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/config_ja.properties
          src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/index.jelly
          src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/Messages.properties
          src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/Messages_ja.properties
          src/main/resources/jp/ikedam/jenkins/plugins/taglib/form/staticSelect.jelly
          src/main/resources/jp/ikedam/jenkins/plugins/taglib/form/staticSelect/staticCombobox.js
          src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest.java
          http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/c9ffba8f0dc1d9dbf35256697cad5ada277303a4
          Log:
          JENKINS-50315 JENKINS-22316 Introduce `editableType` to specify the filtering behavior in editable mode

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition.java src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/config.jelly src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/config_ja.properties src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/index.jelly src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/Messages.properties src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/Messages_ja.properties src/main/resources/jp/ikedam/jenkins/plugins/taglib/form/staticSelect.jelly src/main/resources/jp/ikedam/jenkins/plugins/taglib/form/staticSelect/staticCombobox.js src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest.java http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/c9ffba8f0dc1d9dbf35256697cad5ada277303a4 Log: JENKINS-50315 JENKINS-22316 Introduce `editableType` to specify the filtering behavior in editable mode

          Code changed in jenkins
          User: ikedam
          Path:
          src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition.java
          src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/config.jelly
          src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/config_ja.properties
          src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/index.jelly
          src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/Messages.properties
          src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/Messages_ja.properties
          src/main/resources/jp/ikedam/jenkins/plugins/taglib/form/staticSelect.jelly
          src/main/resources/jp/ikedam/jenkins/plugins/taglib/form/staticSelect/staticCombobox.js
          src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest.java
          http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/b60e33ffd38a295691585c5c9b4c9cd5a6e443d1
          Log:
          Merge pull request #38 from ikedam/feature/JENKINS-50315_SwitchFilterMode

          JENKINS-50315 JENKINS-22316 Introduce `editableType`

          Compare: https://github.com/jenkinsci/extensible-choice-parameter-plugin/compare/5e7570775ff6...b60e33ffd38a
          *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

          Functionality will be removed from GitHub.com on January 31st, 2019.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition.java src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/config.jelly src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/config_ja.properties src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/index.jelly src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/Messages.properties src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/Messages_ja.properties src/main/resources/jp/ikedam/jenkins/plugins/taglib/form/staticSelect.jelly src/main/resources/jp/ikedam/jenkins/plugins/taglib/form/staticSelect/staticCombobox.js src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest.java http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/b60e33ffd38a295691585c5c9b4c9cd5a6e443d1 Log: Merge pull request #38 from ikedam/feature/ JENKINS-50315 _SwitchFilterMode JENKINS-50315 JENKINS-22316 Introduce `editableType` Compare: https://github.com/jenkinsci/extensible-choice-parameter-plugin/compare/5e7570775ff6...b60e33ffd38a * NOTE: * This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

          ikedam added a comment -

          slytigger
          Extensible choice parameter 1.6.0 is released.
          It will be available in the update center in a day.
          You can select the behavior for input value.
          Please try that.

          ikedam added a comment - slytigger Extensible choice parameter 1.6.0 is released. It will be available in the update center in a day. You can select the behavior for input value. Please try that.

          Serge Landry added a comment -

          Will do as soon as updated on our side, which should be shortly. Thanks!

          Serge Landry added a comment - Will do as soon as updated on our side, which should be shortly. Thanks!

          Serge Landry added a comment - - edited

          Good job! The v1.6.0 fixes v1.5.0. You can consider this tested and fixed.

          I will let you close it since I don't want to interfere with your bug/issue lifecycle.

          Serge Landry added a comment - - edited Good job! The v1.6.0 fixes v1.5.0. You can consider this tested and fixed. I will let you close it since I don't want to interfere with your bug/issue lifecycle.

            ikedam ikedam
            slytigger Serge Landry
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: