Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-50336

Optional extensions are not picked up after installing the optional dependency

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved (View Workflow)
    • Minor
    • Resolution: Fixed
    • core
    • None

    Description

      Problem statement

      Consider plugins A and B.

      A has an optional dependency to B.

      B exposes an extension point called B.

      A contains an @Extension(optional=true) or an @OptionalExtension(requiresPlugins = "B") (when using the variant plugin)
      and has public class A extends B.

      • Set up a new Jenkins instance
      • Install plugin A
      • Install plugin B
      • Check groovy console ExtensionList.lookup(B.class)
      • An empty list is returned. Expected to see class A singleton.

      After restarting the Jenkins instance, class A singleton is listed properly.

      Prior/related work

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-49026 Plugins are not installed in right order in case of optional dependency

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. JENKINS-19508 Replace @Extension(optional=true) and optional dependencies with bridge plugins

          • Major - Major loss of function.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-19976 Cannot load a class in depended plugin after install before restart

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-14392 Optional Extensions should be reloaded when dependencies are dynamically loaded

          • Major - Major loss of function.
          • Open
          links to

          Web Link CloudBees Internal TIGER-4517

          Web Link Core PR #3370

          Activity

            Ascending order - Click to sort in descending order
            vlatombe Vincent Latombe created issue -
            vlatombe Vincent Latombe made changes -
            Field Original Value New Value
            Description h1. Problem statement
            Consider plugin A and B. A has an optional dependency to B.

            B exposes an extension point called B

            A contains an {{@Extension(optional=true)}} or an {{@OptionalExtension(requiresPlugins = "B")}} (when using the [variant plugin|https://github.com/jenkinsci/variant-plugin])
            and has {{public class A extends B}}.

            * Set up a new Jenkins instance
            * Install plugin A
            * Install plugin B
            * Check groovy console ExtensionList.lookup(B.class)
            * An empty list is returned. Expected to see class A singleton.

            After restarting the Jenkins instance, class A singleton is listed properly.

            h1. Prior/related work
            * JENKINS-19976 fixed classloading in this kind of situation
            * JENKINS-19508 is proposing to eliminate this use case altogether
            * JENKINS-49026 is a consequence of this problem             		h1. Problem statement
            Consider plugin A and B.

            A has an optional dependency to B.

            B exposes an extension point called B.

            A contains an {{@Extension(optional=true)}} or an {{@OptionalExtension(requiresPlugins = "B")}} (when using the [variant plugin|https://github.com/jenkinsci/variant-plugin])
            and has {{public class A extends B}}.

            * Set up a new Jenkins instance
            * Install plugin A
            * Install plugin B
            * Check groovy console ExtensionList.lookup(B.class)
            * An empty list is returned. Expected to see class A singleton.

            After restarting the Jenkins instance, class A singleton is listed properly.

            h1. Prior/related work
            * JENKINS-19976 fixed classloading in this kind of situation
            * JENKINS-19508 is proposing to eliminate this use case altogether
            * JENKINS-49026 is a consequence of this problem
            vlatombe Vincent Latombe made changes -
            Description h1. Problem statement
            Consider plugin A and B.

            A has an optional dependency to B.

            B exposes an extension point called B.

            A contains an {{@Extension(optional=true)}} or an {{@OptionalExtension(requiresPlugins = "B")}} (when using the [variant plugin|https://github.com/jenkinsci/variant-plugin])
            and has {{public class A extends B}}.

            * Set up a new Jenkins instance
            * Install plugin A
            * Install plugin B
            * Check groovy console ExtensionList.lookup(B.class)
            * An empty list is returned. Expected to see class A singleton.

            After restarting the Jenkins instance, class A singleton is listed properly.

            h1. Prior/related work
            * JENKINS-19976 fixed classloading in this kind of situation
            * JENKINS-19508 is proposing to eliminate this use case altogether
            * JENKINS-49026 is a consequence of this problem             		h1. Problem statement
            Consider plugins *A* and *B*.

            *A* has an optional dependency to *B*.

            *B* exposes an extension point called B.

            *A* contains an {{@Extension(optional=true)}} or an {{@OptionalExtension(requiresPlugins = "B")}} (when using the [variant plugin|https://github.com/jenkinsci/variant-plugin])
            and has {{public class A extends B}}.

            * Set up a new Jenkins instance
            * Install plugin *A*
            * Install plugin *B*
            * Check groovy console {{ExtensionList.lookup(B.class)}}
            * An empty list is returned. Expected to see class *A* singleton.

            After restarting the Jenkins instance, class *A* singleton is listed properly.

            h1. Prior/related work
            * JENKINS-19976 fixed classloading in this kind of situation
            * JENKINS-19508 is proposing to eliminate this use case altogether
            * JENKINS-49026 is a consequence of this problem
            vlatombe Vincent Latombe made changes -
            Link This issue relates to JENKINS-19508 [ JENKINS-19508 ]
            vlatombe Vincent Latombe made changes -
            Link This issue relates to JENKINS-19976 [ JENKINS-19976 ]
            vlatombe Vincent Latombe made changes -
            Link This issue relates to JENKINS-49026 [ JENKINS-49026 ]
            vlatombe Vincent Latombe made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            vlatombe Vincent Latombe made changes -
            Assignee Vincent Latombe [ vlatombe ]
            vlatombe Vincent Latombe made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            vlatombe Vincent Latombe made changes -
            Remote Link This issue links to "Core PR #3370 (Web Link)" [ 20320 ]
            jamesdumay James Dumay made changes -
            Remote Link This issue links to "CloudBees Internal TIGER-4517 (Web Link)" [ 20556 ]
            oleg_nenashev Oleg Nenashev made changes -
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Resolved [ 5 ]
            jglick Jesse Glick made changes -
            Link This issue relates to JENKINS-14392 [ JENKINS-14392 ]

            People

              vlatombe Vincent Latombe
              vlatombe Vincent Latombe
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: