Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-50346

Cannot style build-monitor since 0.4

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • simple-theme-plugin
    • None

      I added a "workaround" to not style build-monitor pages at all (https://github.com/jenkinsci/simple-theme-plugin/commit/cc68d1a82909f6e1fa1f9b4ec2a85b05d738383b) since all styles on GitHub are not aware of that plugin and therefore break its design.

      Unfortunatly some users want to style the build-monitor and now aren't able anymore. This should therefore be user-configurable. Maybe tackle support for styling BlueOcean in a similar way (opt-in, see JENKINS-49081)

          [JENKINS-50346] Cannot style build-monitor since 0.4

          Thomas Rösel added a comment -

          I see a possible solutions here:

          In jenkins-config add a list for ignored classes. These could be evaluated in SimpleThemeDecorator.java
          Replace 

          if (o.getClass().getName().startsWith("com.smartcodeltd.jenkinsci.plugins.buildmonitor")) {
    return false;
}

          with something like

          for (String e : list) {
    if (o.getClass().getName().contains(e)) {
        return false;
    }.
}

          With that solution it would be fully user-configurable, which pages (/plugins) are excluded.

          Thomas Rösel added a comment - I see a possible solutions here: In jenkins-config add a list for ignored classes. These could be evaluated in SimpleThemeDecorator.java Replace if (o.getClass().getName().startsWith( "com.smartcodeltd.jenkinsci.plugins.buildmonitor" )) { return false ; } with something like for ( String e : list) { if (o.getClass().getName().contains(e)) { return false ; }. } With that solution it would be fully user-configurable, which pages (/plugins) are excluded.

            tgr Tobias Gruetzmacher
            tgr Tobias Gruetzmacher
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: