-
New Feature
-
Resolution: Fixed
-
Minor
-
jenkins 2.113
badge-plugin 1.2
-
Powered by SuggestiMate
The new DSL addBadge() allow to create a new badge directly from the pipeline.
How to remove it later on ? In our workflow, there are several pauses waiting for user input, and at each stage we are displaying a different icons (removing previous one and adding a different one).
Here a workaround:
def removeBadges(RunWrapper build, String icon = null) { List<Action> actions = build.getRawBuild().getActions() List<BuildBadgeAction> badgeActions = build.getRawBuild().getActions(BuildBadgeAction.class) for(BuildBadgeAction action : badgeActions) { if (icon == null || action.iconPath == icon) { actions.remove(action) } } }
Would need a removeBadge(icon) and removeAllBadges() methods to do it directly in the pipeline.
[JENKINS-50442] Adding removeBadge(icon) and removeAllBadges() methods to remove existing badges
Started development in this branch: https://github.com/jenkinsci/badge-plugin/commits/removeBadge
I've added an id to the batches.
my intention is to add one method removeBadges() with an optional id parameter. If an id is provided, only the batches with that id are removed. Without an id, all badges will be removed.
jguigui What about my approach?
bakito adding an id in the addBadge() function to later on being able to remove badge(s) selectively in the removeBadges() function will work perfectly for me.
Code changed in jenkins
User: bakito
Path:
README.md
src/main/java/com/jenkinsci/plugins/badge/action/AbstractBadgeAction.java
src/main/java/com/jenkinsci/plugins/badge/annotations/OptionalParam.java
src/main/java/com/jenkinsci/plugins/badge/annotations/Param.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AbstractRemoveBadgesStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AbstractStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AddBadgeStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AddErrorBadgeStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AddHtmlBadgeStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AddInfoBadgeStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AddShortTextStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AddWarningBadgeStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/CreateSummaryStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/RemoveSummariesStep.java
src/test/java/com/jenkinsci/plugins/badge/dsl/AbstractBadgeTest.java
src/test/java/com/jenkinsci/plugins/badge/dsl/AddBadgeStepTest.java
src/test/java/com/jenkinsci/plugins/badge/dsl/AddHtmlBadgeStepTest.java
src/test/java/com/jenkinsci/plugins/badge/dsl/CreateSummaryStepTest.java
src/test/java/com/jenkinsci/plugins/badge/dsl/RemoveBadgesStepTest.java
src/test/java/com/jenkinsci/plugins/badge/dsl/RemoveSummariesStepTest.java
src/test/java/com/jenkinsci/plugins/badge/dsl/ShortTextStepTest.java
src/test/java/com/jenkinsci/plugins/badge/readme/DescribeStepTag.java
http://jenkins-ci.org/commit/badge-plugin/ff3e71832a32b54c9a8738e12aba9262ea14ce95
Log:
extend documentation / support remove for summary https://issues.jenkins-ci.org/browse/JENKINS-50442 https://github.com/jenkinsci/badge-plugin/issues/4
Code changed in jenkins
User: bakito
Path:
README.md
src/main/java/com/jenkinsci/plugins/badge/action/AbstractBadgeAction.java
src/main/java/com/jenkinsci/plugins/badge/action/BadgeAction.java
src/main/java/com/jenkinsci/plugins/badge/action/BadgeSummaryAction.java
src/main/java/com/jenkinsci/plugins/badge/action/HtmlBadgeAction.java
src/main/java/com/jenkinsci/plugins/badge/annotations/OptionalParam.java
src/main/java/com/jenkinsci/plugins/badge/annotations/Param.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AbstractRemoveBadgesStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AbstractStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AddBadgeStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AddErrorBadgeStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AddHtmlBadgeStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AddInfoBadgeStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AddShortTextStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AddWarningBadgeStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/CreateSummaryStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/RemoveBadgesStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/RemoveHtmlBadgesStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/RemoveSummariesStep.java
src/main/resources/com/jenkinsci/plugins/badge/dsl/AddBadgeStep/config.jelly
src/main/resources/com/jenkinsci/plugins/badge/dsl/AddErrorBadgeStep/config.jelly
src/main/resources/com/jenkinsci/plugins/badge/dsl/AddHtmlBadgeStep/config.jelly
src/main/resources/com/jenkinsci/plugins/badge/dsl/AddInfoBadgeStep/config.jelly
src/main/resources/com/jenkinsci/plugins/badge/dsl/AddShortTextStep/config.jelly
src/main/resources/com/jenkinsci/plugins/badge/dsl/AddWarningBadgeStep/config.jelly
src/main/resources/com/jenkinsci/plugins/badge/dsl/CreateSummaryStep/config.jelly
src/test/java/com/jenkinsci/plugins/badge/dsl/AbstractBadgeTest.java
src/test/java/com/jenkinsci/plugins/badge/dsl/AddBadgeStepTest.java
src/test/java/com/jenkinsci/plugins/badge/dsl/AddHtmlBadgeStepTest.java
src/test/java/com/jenkinsci/plugins/badge/dsl/CreateSummaryStepTest.java
src/test/java/com/jenkinsci/plugins/badge/dsl/RemoveBadgesStepTest.java
src/test/java/com/jenkinsci/plugins/badge/dsl/RemoveSummariesStepTest.java
src/test/java/com/jenkinsci/plugins/badge/dsl/ShortTextStepTest.java
src/test/java/com/jenkinsci/plugins/badge/readme/DescribeStepTag.java
src/test/resources/readme/README.tmpl
http://jenkins-ci.org/commit/badge-plugin/29b3d2384d63d5cef786f525aa28dfcf3cc2d951
Log:
add removeBadges methods https://issues.jenkins-ci.org/browse/JENKINS-50442 https://github.com/jenkinsci/badge-plugin/issues/4
update readme
add unit tests https://issues.jenkins-ci.org/browse/JENKINS-50442 https://github.com/jenkinsci/badge-plugin/issues/4
extend documentation / support remove for summary https://issues.jenkins-ci.org/browse/JENKINS-50442 https://github.com/jenkinsci/badge-plugin/issues/4
fix indent
Code changed in jenkins
User: bakito
Path:
README.md
src/main/java/com/jenkinsci/plugins/badge/action/AbstractBadgeAction.java
src/main/java/com/jenkinsci/plugins/badge/action/BadgeAction.java
src/main/java/com/jenkinsci/plugins/badge/action/BadgeSummaryAction.java
src/main/java/com/jenkinsci/plugins/badge/action/HtmlBadgeAction.java
src/main/java/com/jenkinsci/plugins/badge/annotations/OptionalParam.java
src/main/java/com/jenkinsci/plugins/badge/annotations/Param.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AbstractRemoveBadgesStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AbstractStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AddBadgeStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AddErrorBadgeStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AddHtmlBadgeStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AddInfoBadgeStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AddShortTextStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AddWarningBadgeStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/CreateSummaryStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/RemoveBadgesStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/RemoveHtmlBadgesStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/RemoveSummariesStep.java
src/main/resources/com/jenkinsci/plugins/badge/dsl/AddBadgeStep/config.jelly
src/main/resources/com/jenkinsci/plugins/badge/dsl/AddErrorBadgeStep/config.jelly
src/main/resources/com/jenkinsci/plugins/badge/dsl/AddHtmlBadgeStep/config.jelly
src/main/resources/com/jenkinsci/plugins/badge/dsl/AddInfoBadgeStep/config.jelly
src/main/resources/com/jenkinsci/plugins/badge/dsl/AddShortTextStep/config.jelly
src/main/resources/com/jenkinsci/plugins/badge/dsl/AddWarningBadgeStep/config.jelly
src/main/resources/com/jenkinsci/plugins/badge/dsl/CreateSummaryStep/config.jelly
src/test/java/com/jenkinsci/plugins/badge/dsl/AbstractBadgeTest.java
src/test/java/com/jenkinsci/plugins/badge/dsl/AddBadgeStepTest.java
src/test/java/com/jenkinsci/plugins/badge/dsl/AddHtmlBadgeStepTest.java
src/test/java/com/jenkinsci/plugins/badge/dsl/CreateSummaryStepTest.java
src/test/java/com/jenkinsci/plugins/badge/dsl/RemoveBadgesStepTest.java
src/test/java/com/jenkinsci/plugins/badge/dsl/RemoveSummariesStepTest.java
src/test/java/com/jenkinsci/plugins/badge/dsl/ShortTextStepTest.java
src/test/java/com/jenkinsci/plugins/badge/readme/DescribeStepTag.java
src/test/resources/readme/README.tmpl
http://jenkins-ci.org/commit/badge-plugin/1c2cb2f1889c3ddde64d967f1ffc856853a22430
Log:
add removeBadges methods https://issues.jenkins-ci.org/browse/JENKINS-50442 https://github.com/jenkinsci/badge-plugin/issues/4
update readme
add unit tests https://issues.jenkins-ci.org/browse/JENKINS-50442 https://github.com/jenkinsci/badge-plugin/issues/4
extend documentation / support remove for summary https://issues.jenkins-ci.org/browse/JENKINS-50442 https://github.com/jenkinsci/badge-plugin/issues/4
fix indent
Code changed in jenkins
User: bakito
Path:
README.md
src/main/java/com/jenkinsci/plugins/badge/action/AbstractBadgeAction.java
src/main/java/com/jenkinsci/plugins/badge/action/BadgeAction.java
src/main/java/com/jenkinsci/plugins/badge/action/BadgeSummaryAction.java
src/main/java/com/jenkinsci/plugins/badge/action/HtmlBadgeAction.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AbstractRemoveBadgesStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AbstractStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AddBadgeStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AddErrorBadgeStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AddHtmlBadgeStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AddInfoBadgeStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/AddWarningBadgeStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/CreateSummaryStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/RemoveAllBadgesStep.java
src/main/java/com/jenkinsci/plugins/badge/dsl/RemoveHtmlBadgesStep.java
src/main/resources/com/jenkinsci/plugins/badge/dsl/AddBadgeStep/config.jelly
src/main/resources/com/jenkinsci/plugins/badge/dsl/AddErrorBadgeStep/config.jelly
src/main/resources/com/jenkinsci/plugins/badge/dsl/AddHtmlBadgeStep/config.jelly
src/main/resources/com/jenkinsci/plugins/badge/dsl/AddInfoBadgeStep/config.jelly
src/main/resources/com/jenkinsci/plugins/badge/dsl/AddShortTextStep/config.jelly
src/main/resources/com/jenkinsci/plugins/badge/dsl/AddWarningBadgeStep/config.jelly
src/main/resources/com/jenkinsci/plugins/badge/dsl/CreateSummaryStep/config.jelly
src/test/java/com/jenkinsci/plugins/badge/dsl/ShortTextStepTest.java
src/test/java/com/jenkinsci/plugins/badge/readme/DescribeStepTag.java
http://jenkins-ci.org/commit/badge-plugin/8d41519d9111fc4c138f48ff972f03150a0b7cf2
Log:
add removeBadges methods https://issues.jenkins-ci.org/browse/JENKINS-50442