• Icon: New Feature New Feature
    • Resolution: Fixed
    • Icon: Minor Minor
    • jenkins-test-harness
    • None

      I am experimenting with running PCT with WARs generated by Custom WAR Packager. I would like to be able to run JTH and PCT tests against WARs instead of the dependency-based mechanism. It would allow to support things like auto-configuration of WARs which is offered by WAR packager.

          [JENKINS-50598] Add support of running JTH with custom WAR

          Oleg Nenashev added a comment -

          PCT documentation is also in place now: https://github.com/jenkinsci/plugin-compat-tester

          Oleg Nenashev added a comment - PCT documentation is also in place now: https://github.com/jenkinsci/plugin-compat-tester

          What I meant is if the change proposed here is to support the experiment/adoption of the Custom WAR Packager or if there are any other benefits for traditional JTH against core / plugins that has some old problems originating from different dependency handling.

          Oliver Gondža added a comment - What I meant is if the change proposed here is to support the experiment/adoption of the Custom WAR Packager or if there are any other benefits for traditional JTH against core / plugins that has some old problems originating from different dependency handling.

          Oleg Nenashev added a comment -

          olivergondza In the current state I doubt there will be benefit for traditional flows. "Custom WAR packager" enables JTH testing with Bundled plugins/groovy scripts and offers fixes for some issues there (e.g. resolves conflicts between bundled plugins and test dependencies).

          So far I do not see ho these patches could help classic flows which do not bundle plugins or scripts. The proposed patches could be applied to detached plugins, probably.

          Oleg Nenashev added a comment - olivergondza In the current state I doubt there will be benefit for traditional flows. "Custom WAR packager" enables JTH testing with Bundled plugins/groovy scripts and offers fixes for some issues there (e.g. resolves conflicts between bundled plugins and test dependencies). So far I do not see ho these patches could help classic flows which do not bundle plugins or scripts. The proposed patches could be applied to detached plugins, probably.

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/org/jvnet/hudson/test/WarExploder.java
          http://jenkins-ci.org/commit/jenkins-test-harness/e158a39e21f6992617c061b9655c7212a5d7df80
          Log:
          JENKINS-50598 - Add support of passing custom WAR file in WAR exploder using system property

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jvnet/hudson/test/WarExploder.java http://jenkins-ci.org/commit/jenkins-test-harness/e158a39e21f6992617c061b9655c7212a5d7df80 Log: JENKINS-50598 - Add support of passing custom WAR file in WAR exploder using system property

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/org/jvnet/hudson/test/WarExploder.java
          http://jenkins-ci.org/commit/jenkins-test-harness/0ab49c3a6b29268524f492c8faf3cdd20e53f91f
          Log:
          JENKINS-50598 - File type check causes issues in jenkins/pct Docker image when a WAR is passed from volume

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jvnet/hudson/test/WarExploder.java http://jenkins-ci.org/commit/jenkins-test-harness/0ab49c3a6b29268524f492c8faf3cdd20e53f91f Log: JENKINS-50598 - File type check causes issues in jenkins/pct Docker image when a WAR is passed from volume

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/org/jvnet/hudson/test/WarExploder.java
          http://jenkins-ci.org/commit/jenkins-test-harness/282dbfe4031857db549092ba8346dc5c8ee6da3e
          Log:
          Revert "JENKINS-50598 - File type check causes issues in jenkins/pct Docker image when a WAR is passed from volume"

          This reverts commit 0ab49c3a6b29268524f492c8faf3cdd20e53f91f.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jvnet/hudson/test/WarExploder.java http://jenkins-ci.org/commit/jenkins-test-harness/282dbfe4031857db549092ba8346dc5c8ee6da3e Log: Revert " JENKINS-50598 - File type check causes issues in jenkins/pct Docker image when a WAR is passed from volume" This reverts commit 0ab49c3a6b29268524f492c8faf3cdd20e53f91f.

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/org/jvnet/hudson/test/WarExploder.java
          http://jenkins-ci.org/commit/jenkins-test-harness/113e3994aee5c21b77e095dd413313e8ca3ef38c
          Log:
          JENKINS-50598 - Adjust the error message text as suggested by @jglick

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jvnet/hudson/test/WarExploder.java http://jenkins-ci.org/commit/jenkins-test-harness/113e3994aee5c21b77e095dd413313e8ca3ef38c Log: JENKINS-50598 - Adjust the error message text as suggested by @jglick

          Code changed in jenkins
          User: Jesse Glick
          Path:
          src/main/java/org/jvnet/hudson/test/WarExploder.java
          http://jenkins-ci.org/commit/jenkins-test-harness/65d4d94d977d4dedf716a648dbdebf6d3b221b59
          Log:
          Merge pull request #100 from oleg-nenashev/JENKINS-50598-war-option

          JENKINS-50598 - Add support of passing custom WAR file in WAR exploder using system property

          Compare: https://github.com/jenkinsci/jenkins-test-harness/compare/23e497bfa9d7...65d4d94d977d

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jvnet/hudson/test/WarExploder.java http://jenkins-ci.org/commit/jenkins-test-harness/65d4d94d977d4dedf716a648dbdebf6d3b221b59 Log: Merge pull request #100 from oleg-nenashev/ JENKINS-50598 -war-option JENKINS-50598 - Add support of passing custom WAR file in WAR exploder using system property Compare: https://github.com/jenkinsci/jenkins-test-harness/compare/23e497bfa9d7...65d4d94d977d

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          http://jenkins-ci.org/commit/plugin-pom/45c3ffaa5eceddc25ffdf0eab7850ac34c902701
          Log:
          [JENKINS-50598,JENKINS-50590] - Update JTH to 2.38

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/plugin-pom/45c3ffaa5eceddc25ffdf0eab7850ac34c902701 Log: [JENKINS-50598,JENKINS-50590] - Update JTH to 2.38

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          http://jenkins-ci.org/commit/plugin-pom/539cbe295a6782f6cde65cdf7962e6dbb07defb1
          Log:
          Merge pull request #102 from oleg-nenashev/jth/2.38

          [JENKINS-50598,JENKINS-50590] - Update JTH to 2.38

          Compare: https://github.com/jenkinsci/plugin-pom/compare/624a61e2d84b...539cbe295a67

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/plugin-pom/539cbe295a6782f6cde65cdf7962e6dbb07defb1 Log: Merge pull request #102 from oleg-nenashev/jth/2.38 [JENKINS-50598,JENKINS-50590] - Update JTH to 2.38 Compare: https://github.com/jenkinsci/plugin-pom/compare/624a61e2d84b...539cbe295a67

            oleg_nenashev Oleg Nenashev
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: