Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-50540

add the runPCT step to the git-plugin on a PR basis

    • Evergreen - Milestone 1

      We need to modify the git-plugin flow so it runs the PCT on PR basis for git-plugin and all the critical upstream dependencies

       Acceptance criteria

      • For every PR to the git-plugin there is a run of the PCT exercising all git-plugin upstream dependencies
      • The run has to be against a TBD version of Jenkins core
        • Latest one
        • The one included in essentials
        • Latest LTS
      • What are the versions of the git-plugin dependencies to use? TBD cc jglick rarabaolaza oleg_nenashev
        • For example the ones included in essentials, the latest ones? Or more generally, what environment are we going to use for this PCT run? The UC, a custom UC generated from essentials.yml a war file generated from the new custom war packager tool using essentials.yml as source...

          [JENKINS-50540] add the runPCT step to the git-plugin on a PR basis

          JENKINS-51008 created as a follow up

          Raul Arabaolaza added a comment - JENKINS-51008 created as a follow up

          So I have the flow already implemented but I am having failing tests in PCT, checking now how to fix them as I want to start the flow with a green build

          Raul Arabaolaza added a comment - So I have the flow already implemented but I am having failing tests in PCT, checking now how to fix them as I want to start the flow with a green build

          I suspect at least one problem is the lack of the .git folder in the sources run by the PCT as I am stashing with default exclusions and some of the errors refer to the lack of a plugin repo AFAIUI in the sources folder, so testing now without default excludes

          Raul Arabaolaza added a comment - I suspect at least one problem is the lack of the .git folder in the sources run by the PCT as I am stashing with default exclusions and some of the errors refer to the lack of a plugin repo AFAIUI in the sources folder, so testing now without default excludes

          Also the code used in runPCT for copying plugin sources to the proper dir was not copying hidden files

          Raul Arabaolaza added a comment - Also the code used in runPCT for copying plugin sources to the proper dir was not copying hidden files

          Raul Arabaolaza added a comment - - edited

          PCT#75 and some changes in the Jenkinsfile seems to solve the failing PCT tests

          And also pipeline-library#48

          Raul Arabaolaza added a comment - - edited PCT#75 and some changes in the Jenkinsfile seems to solve the failing PCT tests And also pipeline-library#48

          Code changed in jenkins
          User: Raul Arabaolaza
          Path:
          src/main/docker/run-pct.sh
          http://jenkins-ci.org/commit/plugin-compat-tester/17058d791b8e69b02950481093701059d5229046
          Log:
          JENKINS-50540 Make sure to copy hidden files (like .git) on custom sources

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Raul Arabaolaza Path: src/main/docker/run-pct.sh http://jenkins-ci.org/commit/plugin-compat-tester/17058d791b8e69b02950481093701059d5229046 Log: JENKINS-50540 Make sure to copy hidden files (like .git) on custom sources

          Code changed in jenkins
          User: Raúl Arabaolaza Barquin
          Path:
          src/main/docker/run-pct.sh
          http://jenkins-ci.org/commit/plugin-compat-tester/7ff1ce59b4d9ebb01b70b9fc77443dee45cbd5e3
          Log:
          Merge pull request #75 from raul-arabaolaza/JENKINS-50540

          JENKINS-50540 Make sure to copy hidden files (like .git) on custom sources

          Compare: https://github.com/jenkinsci/plugin-compat-tester/compare/f0d0ce72c68f...7ff1ce59b4d9

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Raúl Arabaolaza Barquin Path: src/main/docker/run-pct.sh http://jenkins-ci.org/commit/plugin-compat-tester/7ff1ce59b4d9ebb01b70b9fc77443dee45cbd5e3 Log: Merge pull request #75 from raul-arabaolaza/ JENKINS-50540 JENKINS-50540 Make sure to copy hidden files (like .git) on custom sources Compare: https://github.com/jenkinsci/plugin-compat-tester/compare/f0d0ce72c68f...7ff1ce59b4d9

          Code changed in jenkins
          User: Raul Arabaolaza
          Path:
          Jenkinsfile
          http://jenkins-ci.org/commit/git-plugin/4e838dac2f56110b410ae749d5ecbdc8ca3ae40c
          Log:
          JENKINS-50540 Keep .git folder for tests

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Raul Arabaolaza Path: Jenkinsfile http://jenkins-ci.org/commit/git-plugin/4e838dac2f56110b410ae749d5ecbdc8ca3ae40c Log: JENKINS-50540 Keep .git folder for tests

          Code changed in jenkins
          User: Raul Arabaolaza
          Path:
          Jenkinsfile
          http://jenkins-ci.org/commit/git-plugin/27030980db49467d0169ed8671aebceb572c0c46
          Log:
          JENKINS-50540 runPCT already includes the log option

          Plus there is no need to delete anything after runPCT

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Raul Arabaolaza Path: Jenkinsfile http://jenkins-ci.org/commit/git-plugin/27030980db49467d0169ed8671aebceb572c0c46 Log: JENKINS-50540 runPCT already includes the log option Plus there is no need to delete anything after runPCT

          Mark Waite added a comment -

          Included in git plugin 3.9.0 released 12 May 2018

          Mark Waite added a comment - Included in git plugin 3.9.0 released 12 May 2018

            rarabaolaza Raul Arabaolaza
            vilacides Isa Vilacides
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: