Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-50634

Triggered probe option

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • p4-plugin
    • v1.8.4

      Please add a check whether a job is disabled before performing probing.

      Currently (as with v1.8.4) even disabled jobs are considered acc. to jenkins.log.

          [JENKINS-50634] Triggered probe option

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Paul Allen
          Path:
          src/main/java/org/jenkinsci/plugins/p4/trigger/P4Hook.java
          src/test/java/org/jenkinsci/plugins/p4/DefaultEnvironment.java
          src/test/java/org/jenkinsci/plugins/p4/client/PollingTest.java
          http://jenkins-ci.org/commit/p4-plugin/3d037546b4230d57c5a3045182bde967aab38e23
          Log:
          Skip probing disabled Jobs.

          Includes minor updates to Polling tests. JENKINS-50634

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Paul Allen Path: src/main/java/org/jenkinsci/plugins/p4/trigger/P4Hook.java src/test/java/org/jenkinsci/plugins/p4/DefaultEnvironment.java src/test/java/org/jenkinsci/plugins/p4/client/PollingTest.java http://jenkins-ci.org/commit/p4-plugin/3d037546b4230d57c5a3045182bde967aab38e23 Log: Skip probing disabled Jobs. Includes minor updates to Polling tests. JENKINS-50634

          Paul Allen added a comment -

          Ready for release.

          Paul Allen added a comment - Ready for release.

          Heiko Nardmann added a comment -

          What is this new TestHandler class for?
           

          Heiko Nardmann added a comment - What is this new TestHandler class for?  

          Paul Allen added a comment -

          I used it in the Polling tests to verify the polling log contains certain strings.  Perhaps a bit excessive, but I wanted to make sure that polling was functionally working.  I could have mocked the Logger and TaskListener classes, but the TestHangler gives me more flexibility and allows me to use it for any tests where I want to peek into a TaskListener log.  

          Paul Allen added a comment - I used it in the Polling tests to verify the polling log contains certain strings.  Perhaps a bit excessive, but I wanted to make sure that polling was functionally working.  I could have mocked the Logger and TaskListener classes, but the TestHangler gives me more flexibility and allows me to use it for any tests where I want to peek into a TaskListener log.  

          Paul Allen added a comment -

          For reference TestHandler was introduced in the previous change, to test polling filters: https://github.com/jenkinsci/p4-plugin/commit/d330bbc02e7e0408649682be08a459b10609b3eb

          It was a refactor in the P4Hook changes.

          Paul Allen added a comment - For reference TestHandler was introduced in the previous change, to test polling filters: https://github.com/jenkinsci/p4-plugin/commit/d330bbc02e7e0408649682be08a459b10609b3eb It was a refactor in the P4Hook changes.

          Paul Allen added a comment -

          Released in 1.8.9

          Paul Allen added a comment - Released in 1.8.9

            p4paul Paul Allen
            heiko_nardmann Heiko Nardmann
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: