Major Now JEP 308 has been merged as draft, we should double check the code does comply to the spec.
At least:
- Test cover the expected http status codes described in the specification
- Example: send data too big and expect the HTTP 413 status code (see https://github.com/jenkinsci/jep/tree/master/jep/308#maximum-message-size)
- Retrieve and log instance identity along with the log for correlation
- is blocked by
-
JENKINS-51140 Design (JEP) what the Error Telemetry API will be
-
- Resolved
-
- links to
[JENKINS-51391] Adjust error telemetry API to JEP-308
asmith_cb FYI, when we put things in review, we try to put links to PR as links from here. For volume reasons, we can unfortunately not use the auto-linking feature between JIRA and GitHub's PRs, this burns the API quota too fast :-\.
The express framework is doing the payload size check before parsing the JSON. The 413 response being thrown is being turned into a 500 response. This needs further troubleshooting with the error handling layer.