Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-51541

SlaveComputer should support creating channels with custom ChannelBuilder

      While working on the design for JENKINS-51413, I and pvtuan10 noticed that SlaveComputer#setChannel() interface allows creating channels only based on I/O streams albeit the Channel logic itself and ChannelBuilders support other command transports.

      I propose to add a new API methods so that other channel implementations can be defined by ComputerLaunchers (see Option 2 in JENKINS-51413)

          [JENKINS-51541] SlaveComputer should support creating channels with custom ChannelBuilder

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/slaves/SlaveComputer.java
          pom.xml
          http://jenkins-ci.org/commit/jenkins/c405ae701c4bca18f7b4edc6e5cd3bc053b7ee60
          Log:
          [JENKINS-51541,JENKINS-51551,...] - Remoting 3.21 + Allow passing custom CommandTransport implementations to SlaveComputer from ComputerLauncher (#3455)

          • JENKINS-51541 - Introduce new SlaveComputer#setChannel() method which takes custom ChannelBuilder and CommandTransport
          • JENKINS-51541 - Listener is nullable according to the documentation
          • [JENKINS-51551,JENKINS-51223,JENKINS-50965] - Update Remoting to 3.21
          • JENKINS-51541 - Restrict SlaveComputer#setChannel(ChannelBuilder cb, …) to Beta-use only

          *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

          Functionality will be removed from GitHub.com on January 31st, 2019.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/slaves/SlaveComputer.java pom.xml http://jenkins-ci.org/commit/jenkins/c405ae701c4bca18f7b4edc6e5cd3bc053b7ee60 Log: [JENKINS-51541,JENKINS-51551,...] - Remoting 3.21 + Allow passing custom CommandTransport implementations to SlaveComputer from ComputerLauncher (#3455) JENKINS-51541 - Introduce new SlaveComputer#setChannel() method which takes custom ChannelBuilder and CommandTransport JENKINS-51551 - Pick Remoting version with the API patch JENKINS-51541 - Listener is nullable according to the documentation [JENKINS-51551,JENKINS-51223,JENKINS-50965] - Update Remoting to 3.21 JENKINS-51541 - Restrict SlaveComputer#setChannel(ChannelBuilder cb, …) to Beta-use only * NOTE: * This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

          Oleg Nenashev added a comment -

          Fixed in Jenkins 2.127

          Oleg Nenashev added a comment - Fixed in Jenkins 2.127

            oleg_nenashev Oleg Nenashev
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: