Status: Resolved (View Workflow)
While working on the design for
JENKINS-51413, I and pvtuan10 noticed that SlaveComputer#setChannel() interface allows creating channels only based on I/O streams albeit the Channel logic itself and ChannelBuilders support other command transports.
I propose to add a new API methods so that other channel implementations can be defined by ComputerLaunchers (see Option 2 in
- relates to
JENKINS-51413 Implementation of producer-consumer basic communication
JENKINS-51551 Allow CommandTransport and its sub-classes to be sub-typed from outside
Code changed in jenkins
User: Oleg Nenashev
[JENKINS-51541,JENKINS-51551,...] - Remoting 3.21 + Allow passing custom CommandTransport implementations to SlaveComputer from ComputerLauncher (#3455)
JENKINS-51541- Introduce new SlaveComputer#setChannel() method which takes custom ChannelBuilder and CommandTransport JENKINS-51551- Pick Remoting version with the API patch JENKINS-51541- Listener is nullable according to the documentation JENKINS-51541- Restrict SlaveComputer#setChannel(ChannelBuilder cb, …) to Beta-use only
*NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.