• Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • m2release-plugin
    • None

      thanks for the plugin

      • However why do you not propose to use SCM conf job for releasing instead of forcing user to declare SCM parameters in the pom.xml ?
      • BIG PROBLEM : you tag on the SCM with the job name suffixed by the release number. WHY ? Ex :
        INFO Tagging release with the label test-14-standard-web-1_0_0_0_3...

      Instead of tagging my test-14-standard-web with v1_0_0_0_3 as requested in the input release field before the release action.

      So because our SCM check the tag syntax the action is rejected

      It is not the plugin but maven-release-plugin that is responsible of this

      (http://jira.codehaus.org/browse/MRELEASE-159, http://jira.codehaus.org/browse/MRELEASE-150)

      but How can I configure it

      I must give the -Dtag=v1_0_0_0_3 parameter to release:prepare but it will be fine if M2 release plugin could display on the action page, a input field with the SCM tag (with a default value)

      Can I create a issue ?

        1. m2release.patch
          12 kB
        2. m2release.patch
          9 kB
        3. screenshot-1.jpg
          screenshot-1.jpg
          175 kB

          [JENKINS-5171] Add a way to change the SCM release Tag

          fabrice31 added a comment -

          I realize the developpement need for choose a tag.
          Please see attached screenshot file.
          Il will include the patch diff later.

          fabrice31 added a comment - I realize the developpement need for choose a tag. Please see attached screenshot file. Il will include the patch diff later.

          James Nord added a comment -

          The version needs to be outside of the module iteration as it is a global define not per module - also the patch is very specific to your organization matching the v_ in the tag to compute the version.

          Also can the language be English please to fit with the rest of the plugin.

          If you wish to produce a french localized version can you provide me with a translation of the Strings used in the files under a different JIRA?

          Can you produce a patch which addresses these issues?

          James Nord added a comment - The version needs to be outside of the module iteration as it is a global define not per module - also the patch is very specific to your organization matching the v_ in the tag to compute the version. Also can the language be English please to fit with the rest of the plugin. If you wish to produce a french localized version can you provide me with a translation of the Strings used in the files under a different JIRA? Can you produce a patch which addresses these issues?

          pierrebocquet added a comment -

          It's a new patch including teilo's modification request

          pierrebocquet added a comment - It's a new patch including teilo's modification request

          Code changed in jenkins
          User: James Nord
          Path:
          src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseAction.java
          src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBuildWrapper.java
          src/main/resources/org/jvnet/hudson/plugins/m2release/M2ReleaseAction/index.jelly
          src/main/webapp/help-actionRelease-specifyCustomScmTag.html
          http://jenkins-ci.org/commit/m2release-plugin/743ee2555468b77ac6683d08956a546e56aa07f2
          Log:
          [FIXED JENKINS-7295]
          [FIXED JENKINS-5171]
          added ability to specify the SCM tag.

          Compare: https://github.com/jenkinsci/m2release-plugin/compare/384c610...743ee25

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: James Nord Path: src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseAction.java src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBuildWrapper.java src/main/resources/org/jvnet/hudson/plugins/m2release/M2ReleaseAction/index.jelly src/main/webapp/help-actionRelease-specifyCustomScmTag.html http://jenkins-ci.org/commit/m2release-plugin/743ee2555468b77ac6683d08956a546e56aa07f2 Log: [FIXED JENKINS-7295] [FIXED JENKINS-5171] added ability to specify the SCM tag. Compare: https://github.com/jenkinsci/m2release-plugin/compare/384c610...743ee25

          Code changed in jenkins
          User: James Nord
          Path:
          src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBuildWrapper.java
          http://jenkins-ci.org/commit/m2release-plugin/654e89074d6fa7a23052f82e588db925fe34d3c4
          Log:
          [FIXED JENKINS-7295]
          [FIXED JENKINS-5171]

          Add a space after the tag so the arguments for the tag don't end up including the release goals.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: James Nord Path: src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBuildWrapper.java http://jenkins-ci.org/commit/m2release-plugin/654e89074d6fa7a23052f82e588db925fe34d3c4 Log: [FIXED JENKINS-7295] [FIXED JENKINS-5171] Add a space after the tag so the arguments for the tag don't end up including the release goals.

          Open but fixed ??
          I reviewed the last patch and it seems to be good. I will try the snapshot.

          Arnaud Héritier added a comment - Open but fixed ?? I reviewed the last patch and it seems to be good. I will try the snapshot.

          James Nord added a comment -

          will be in 0.8.0

          James Nord added a comment - will be in 0.8.0

            Unassigned Unassigned
            fabrice31 fabrice31
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: