SlaveComputer#setChannel(Channel,OutputStream,Channel.Listener) may throw null in the case of valid API usages

This issue is archived. You can view it, but you can't modify it. Learn more

XMLWordPrintable

      The second parameter for SlaveComputer#setChannel(Channel,OutputStream,Channel.Listener) is launchLog.

      According to Javadoc of another method, it may be null. " If non-null, receive the portion of data in <tt>is</tt> before the data goes into the binary mode.

      public void setChannel(@Nonnull InputStream in, @Nonnull OutputStream out,
                                 @CheckForNull OutputStream launchLog,
                                 @CheckForNull Channel.Listener listener
      

      If somebody really passes null to that method the underlying 3-argument method will fail with NPE. Although I think that loggers should be always passed, I think that the valid fix would be to have null handling so that API users do not get into the same risk

            Assignee:
            Oleg Nenashev
            Reporter:
            Oleg Nenashev
            Archiver:
            Jenkins Service Account

              Created:
              Updated:
              Resolved:
              Archived: