Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-51971

StreamTaskListener#getCharset() may violate API and return null


    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core

      Current state:

      • API users may get NPE if they handle TaskListener according to the requirements

      Nonnull annotation has been introduced by jglick in https://github.com/jenkinsci/jenkins/commit/9ed6b01317424f3f441022b3a2f23fbbc5ae1543

      I see two options:

      • Relax requirements in TaskListener#getCharset() and allow null returns. It is a "breaking change" from API PoV (now we require API users to check for nulls)
      • Rework StreamTaskListener to disallow nulls and to default to something (UTF-8). May break some use-cases as well since now it defaults to the system's default charset

            Unassigned Unassigned
            oleg_nenashev Oleg Nenashev
            0 Vote for this issue
            2 Start watching this issue