Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5249

Computer.getHostName fails when it could work

    XMLWordPrintable

    Details

    • Type: Patch
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      As discussed in http://n4.nabble.com/Hudson-and-Selenium-Unable-to-determine-the-host-name-Skipping-Selenium-execution-tp956619p956791.html some operations and plugins can fail due to the way Computer.getHostName works - basically Hudson thinks it is unable to ping a slave even though the slave really is reachable from the master.

      This patch turns the way a slave is pinged into an extension point so people can implement custom ways of pinging - for example calling out to the ping command of the OS. An implementation of the extension point is included that maintains the current mechanism, so by default there should be no change in behavior.

      The extension-point/default-implementation approach follows the pattern of the ssh-slaves plugin, which uses an extension point in locating a JVM on the slave.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : kohsuke
          Path:
          trunk/hudson/main/core/src/main/java/hudson/model/Computer.java
          trunk/hudson/main/core/src/main/java/hudson/model/ComputerPinger.java
          trunk/www/changelog.html
          http://jenkins-ci.org/commit/35023
          Log:
          [FIXED JENKINS-5249] Made the ping behaviour customizable.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : kohsuke Path: trunk/hudson/main/core/src/main/java/hudson/model/Computer.java trunk/hudson/main/core/src/main/java/hudson/model/ComputerPinger.java trunk/www/changelog.html http://jenkins-ci.org/commit/35023 Log: [FIXED JENKINS-5249] Made the ping behaviour customizable.
          Hide
          dogfood dogfood added a comment -

          Integrated in hudson_main_trunk #283
          [FIXED JENKINS-5249] Made the ping behaviour customizable.

          kohsuke :
          Files :

          • /trunk/hudson/main/core/src/main/java/hudson/model/Computer.java
          • /trunk/hudson/main/core/src/main/java/hudson/model/ComputerPinger.java
          • /trunk/www/changelog.html
          Show
          dogfood dogfood added a comment - Integrated in hudson_main_trunk #283 [FIXED JENKINS-5249] Made the ping behaviour customizable. kohsuke : Files : /trunk/hudson/main/core/src/main/java/hudson/model/Computer.java /trunk/hudson/main/core/src/main/java/hudson/model/ComputerPinger.java /trunk/www/changelog.html

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            nparry Nathan Parry
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: