Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-52592

After parent pom update, MessageOriginIdentityTest passes when run alone, fails when run with others

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • pubsub-light-plugin
    • None

      Summary
      When building pubsub-light-plugin, the test MessageOriginIdentityTest passes if run by itself, as with a mvn clean test -Dtest=MessageOriginIdentityTest. But when run along with the remaining tests as with a regular mvn clean test, the test fails.

      Other findings
      I renamed MessageOriginIdentityTest to AAMessageOriginIdentityTest. This caused the test to pass just fine when run in the group, I suppose because it was run first?

          [JENKINS-52592] After parent pom update, MessageOriginIdentityTest passes when run alone, fails when run with others

          Karl Shultz added a comment -

          Example passing test when run alone:

          -------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.jenkinsci.plugins.pubsub.MessageOriginIdentityTest
Jul 16, 2018 4:20:55 PM org.eclipse.jetty.util.log.Log initialized
INFO: Logging initialized @341ms
Exploding /home/kshultz/.m2/repository/org/jenkins-ci/main/jenkins-war/1.625.3/jenkins-war-1.625.3-war-for-test.jar into /home/kshultz/GitHub/pubsub-light-module/target/jenkins-for-test
Jul 16, 2018 4:20:57 PM org.eclipse.jetty.server.Server doStart
INFO: jetty-9.2.15.v20160210
Jul 16, 2018 4:20:57 PM org.eclipse.jetty.webapp.StandardDescriptorProcessor visitServlet
INFO: NO JSP Support for /jenkins, did not find org.eclipse.jetty.jsp.JettyJspServlet
Jul 16, 2018 4:20:57 PM org.eclipse.jetty.server.handler.ContextHandler doStart
INFO: Started o.e.j.w.WebAppContext@19b93fa8{/jenkins,file:/home/kshultz/GitHub/pubsub-light-module/target/jenkins-for-test/,AVAILABLE}{/home/kshultz/GitHub/pubsub-light-module/target/jenkins-for-test}
Jul 16, 2018 4:20:57 PM org.eclipse.jetty.server.AbstractConnector doStart
INFO: Started ServerConnector@2a62b5bc{HTTP/1.1}{localhost:46143}
Jul 16, 2018 4:20:57 PM org.eclipse.jetty.server.Server doStart
INFO: Started @2028ms
Jul 16, 2018 4:20:57 PM org.jvnet.hudson.test.JenkinsRule createWebServer
INFO: Running on http://localhost:46143/jenkins/
Jul 16, 2018 4:20:57 PM jenkins.InitReactorRunner$1 onAttained
INFO: Started initialization
Jul 16, 2018 4:21:05 PM jenkins.InitReactorRunner$1 onAttained
INFO: Listed all plugins
Jul 16, 2018 4:21:07 PM jenkins.InitReactorRunner$1 onAttained
INFO: Prepared all plugins
Jul 16, 2018 4:21:07 PM jenkins.InitReactorRunner$1 onAttained
INFO: Started all plugins
Jul 16, 2018 4:21:07 PM jenkins.InitReactorRunner$1 onAttained
INFO: Augmented all extensions
Jul 16, 2018 4:21:08 PM jenkins.InitReactorRunner$1 onAttained
INFO: Loaded all jobs
Jul 16, 2018 4:21:08 PM org.jenkinsci.main.modules.sshd.SSHD start
INFO: Started SSHD at port 33813
Jul 16, 2018 4:21:08 PM jenkins.InitReactorRunner$1 onAttained
INFO: Completed initialization
Jul 16, 2018 4:21:08 PM jenkins.InitReactorRunner$1 onAttained
INFO: Started initialization
Jul 16, 2018 4:21:08 PM jenkins.InitReactorRunner$1 onAttained
INFO: Listed all plugins
Jul 16, 2018 4:21:08 PM jenkins.InitReactorRunner$1 onAttained
INFO: Prepared all plugins
Jul 16, 2018 4:21:08 PM jenkins.InitReactorRunner$1 onAttained
INFO: Started all plugins
Jul 16, 2018 4:21:08 PM jenkins.InitReactorRunner$1 onAttained
INFO: Augmented all extensions
Jul 16, 2018 4:21:08 PM jenkins.InitReactorRunner$1 onAttained
INFO: Loaded all jobs
Jul 16, 2018 4:21:08 PM jenkins.InitReactorRunner$1 onAttained
INFO: Completed initialization
Jul 16, 2018 4:21:09 PM org.eclipse.jetty.server.Server doStart
INFO: jetty-9.2.15.v20160210
Jul 16, 2018 4:21:09 PM org.eclipse.jetty.server.handler.ContextHandler doStart
INFO: Started o.e.j.s.ServletContextHandler@54227100{/,null,AVAILABLE}
Jul 16, 2018 4:21:09 PM org.eclipse.jetty.server.AbstractConnector doStart
INFO: Started ServerConnector@7829b776{HTTP/1.1}{0.0.0.0:33935}
Jul 16, 2018 4:21:09 PM org.eclipse.jetty.server.Server doStart
INFO: Started @13489ms
=== Starting test(org.jenkinsci.plugins.pubsub.MessageOriginIdentityTest)
Jul 16, 2018 4:21:09 PM org.eclipse.jetty.server.AbstractConnector doStop
INFO: Stopped ServerConnector@2a62b5bc{HTTP/1.1}{localhost:0}
Jul 16, 2018 4:21:09 PM org.eclipse.jetty.server.handler.ContextHandler doStop
INFO: Stopped o.e.j.w.WebAppContext@19b93fa8{/jenkins,file:/home/kshultz/GitHub/pubsub-light-module/target/jenkins-for-test/,UNAVAILABLE}{/home/kshultz/GitHub/pubsub-light-module/target/jenkins-for-test}
Jul 16, 2018 4:21:09 PM jenkins.model.Jenkins cleanUp
INFO: Stopping Jenkins
Jul 16, 2018 4:21:09 PM jenkins.model.Jenkins$22 onAttained
INFO: Started termination
Jul 16, 2018 4:21:09 PM jenkins.model.Jenkins$22 onAttained
INFO: Completed termination
Jul 16, 2018 4:21:09 PM jenkins.model.Jenkins _cleanUpDisconnectComputers
INFO: Starting node disconnection
Jul 16, 2018 4:21:09 PM hudson.TcpSlaveAgentListener$ConnectionHandler run
INFO: Accepted connection #1 from /192.168.122.1:44582
Jul 16, 2018 4:21:09 PM jenkins.model.Jenkins _cleanUpShutdownPluginManager
INFO: Stopping plugin manager
Jul 16, 2018 4:21:09 PM jenkins.model.Jenkins _cleanUpPersistQueue
INFO: Persisting build queue
Jul 16, 2018 4:21:09 PM jenkins.model.Jenkins _cleanUpAwaitDisconnects
INFO: Waiting for node disconnection completion
WARN: The method class org.apache.commons.logging.impl.SLF4JLogFactory#release() was invoked.
WARN: Please see http://www.slf4j.org/codes.html#release for an explanation.
Jul 16, 2018 4:21:09 PM jenkins.model.Jenkins cleanUp
INFO: Jenkins stopped
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.243 sec - in org.jenkinsci.plugins.pubsub.MessageOriginIdentityTest

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 26.294 s
[INFO] Finished at: 2018-07-16T16:21:10-04:00
[INFO] Final Memory: 55M/1114M
[INFO] ------------------------------------------------------------------------

          Karl Shultz added a comment - Example passing test when run alone: ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.jenkinsci.plugins.pubsub.MessageOriginIdentityTest Jul 16, 2018 4:20:55 PM org.eclipse.jetty.util.log.Log initialized INFO: Logging initialized @341ms Exploding /home/kshultz/.m2/repository/org/jenkins-ci/main/jenkins-war/1.625.3/jenkins-war-1.625.3-war-for-test.jar into /home/kshultz/GitHub/pubsub-light-module/target/jenkins-for-test Jul 16, 2018 4:20:57 PM org.eclipse.jetty.server.Server doStart INFO: jetty-9.2.15.v20160210 Jul 16, 2018 4:20:57 PM org.eclipse.jetty.webapp.StandardDescriptorProcessor visitServlet INFO: NO JSP Support for /jenkins, did not find org.eclipse.jetty.jsp.JettyJspServlet Jul 16, 2018 4:20:57 PM org.eclipse.jetty.server.handler.ContextHandler doStart INFO: Started o.e.j.w.WebAppContext@19b93fa8{/jenkins,file:/home/kshultz/GitHub/pubsub-light-module/target/jenkins-for-test/,AVAILABLE}{/home/kshultz/GitHub/pubsub-light-module/target/jenkins-for-test} Jul 16, 2018 4:20:57 PM org.eclipse.jetty.server.AbstractConnector doStart INFO: Started ServerConnector@2a62b5bc{HTTP/1.1}{localhost:46143} Jul 16, 2018 4:20:57 PM org.eclipse.jetty.server.Server doStart INFO: Started @2028ms Jul 16, 2018 4:20:57 PM org.jvnet.hudson.test.JenkinsRule createWebServer INFO: Running on http://localhost:46143/jenkins/ Jul 16, 2018 4:20:57 PM jenkins.InitReactorRunner$1 onAttained INFO: Started initialization Jul 16, 2018 4:21:05 PM jenkins.InitReactorRunner$1 onAttained INFO: Listed all plugins Jul 16, 2018 4:21:07 PM jenkins.InitReactorRunner$1 onAttained INFO: Prepared all plugins Jul 16, 2018 4:21:07 PM jenkins.InitReactorRunner$1 onAttained INFO: Started all plugins Jul 16, 2018 4:21:07 PM jenkins.InitReactorRunner$1 onAttained INFO: Augmented all extensions Jul 16, 2018 4:21:08 PM jenkins.InitReactorRunner$1 onAttained INFO: Loaded all jobs Jul 16, 2018 4:21:08 PM org.jenkinsci.main.modules.sshd.SSHD start INFO: Started SSHD at port 33813 Jul 16, 2018 4:21:08 PM jenkins.InitReactorRunner$1 onAttained INFO: Completed initialization Jul 16, 2018 4:21:08 PM jenkins.InitReactorRunner$1 onAttained INFO: Started initialization Jul 16, 2018 4:21:08 PM jenkins.InitReactorRunner$1 onAttained INFO: Listed all plugins Jul 16, 2018 4:21:08 PM jenkins.InitReactorRunner$1 onAttained INFO: Prepared all plugins Jul 16, 2018 4:21:08 PM jenkins.InitReactorRunner$1 onAttained INFO: Started all plugins Jul 16, 2018 4:21:08 PM jenkins.InitReactorRunner$1 onAttained INFO: Augmented all extensions Jul 16, 2018 4:21:08 PM jenkins.InitReactorRunner$1 onAttained INFO: Loaded all jobs Jul 16, 2018 4:21:08 PM jenkins.InitReactorRunner$1 onAttained INFO: Completed initialization Jul 16, 2018 4:21:09 PM org.eclipse.jetty.server.Server doStart INFO: jetty-9.2.15.v20160210 Jul 16, 2018 4:21:09 PM org.eclipse.jetty.server.handler.ContextHandler doStart INFO: Started o.e.j.s.ServletContextHandler@54227100{/,null,AVAILABLE} Jul 16, 2018 4:21:09 PM org.eclipse.jetty.server.AbstractConnector doStart INFO: Started ServerConnector@7829b776{HTTP/1.1}{0.0.0.0:33935} Jul 16, 2018 4:21:09 PM org.eclipse.jetty.server.Server doStart INFO: Started @13489ms === Starting test(org.jenkinsci.plugins.pubsub.MessageOriginIdentityTest) Jul 16, 2018 4:21:09 PM org.eclipse.jetty.server.AbstractConnector doStop INFO: Stopped ServerConnector@2a62b5bc{HTTP/1.1}{localhost:0} Jul 16, 2018 4:21:09 PM org.eclipse.jetty.server.handler.ContextHandler doStop INFO: Stopped o.e.j.w.WebAppContext@19b93fa8{/jenkins,file:/home/kshultz/GitHub/pubsub-light-module/target/jenkins-for-test/,UNAVAILABLE}{/home/kshultz/GitHub/pubsub-light-module/target/jenkins-for-test} Jul 16, 2018 4:21:09 PM jenkins.model.Jenkins cleanUp INFO: Stopping Jenkins Jul 16, 2018 4:21:09 PM jenkins.model.Jenkins$22 onAttained INFO: Started termination Jul 16, 2018 4:21:09 PM jenkins.model.Jenkins$22 onAttained INFO: Completed termination Jul 16, 2018 4:21:09 PM jenkins.model.Jenkins _cleanUpDisconnectComputers INFO: Starting node disconnection Jul 16, 2018 4:21:09 PM hudson.TcpSlaveAgentListener$ConnectionHandler run INFO: Accepted connection #1 from /192.168.122.1:44582 Jul 16, 2018 4:21:09 PM jenkins.model.Jenkins _cleanUpShutdownPluginManager INFO: Stopping plugin manager Jul 16, 2018 4:21:09 PM jenkins.model.Jenkins _cleanUpPersistQueue INFO: Persisting build queue Jul 16, 2018 4:21:09 PM jenkins.model.Jenkins _cleanUpAwaitDisconnects INFO: Waiting for node disconnection completion WARN: The method class org.apache.commons.logging.impl.SLF4JLogFactory#release() was invoked. WARN: Please see http://www.slf4j.org/codes.html#release for an explanation. Jul 16, 2018 4:21:09 PM jenkins.model.Jenkins cleanUp INFO: Jenkins stopped Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.243 sec - in org.jenkinsci.plugins.pubsub.MessageOriginIdentityTest Results : Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 26.294 s [INFO] Finished at: 2018-07-16T16:21:10-04:00 [INFO] Final Memory: 55M/1114M [INFO] ------------------------------------------------------------------------

          Karl Shultz added a comment -

          I'm assigning this to me for the time being. I hit the problem while trying to upgrade the plugin parent pom to 3.15 to fix some PCT failures. As it sits (with the old parent pom) the tests pass fine. So, it's only once the plugin has been brought up to parent 3.15 that this starts to show itself.

          I'll keep working at it.

          Karl Shultz added a comment - I'm assigning this to me for the time being. I hit the problem while trying to upgrade the plugin parent pom to 3.15 to fix some PCT failures. As it sits (with the old parent pom) the tests pass fine. So, it's only once the plugin has been brought up to parent 3.15 that this starts to show itself. I'll keep working at it.

          Tom FENNELLY added a comment - - edited

          I just had a look and can see that test is using JenkinsRule. I'm fairly sure that's not thread safe. I think you'll need to annotate the test as @NotThreadSafe.

          Tom FENNELLY added a comment - - edited I just had a look and can see that test is using JenkinsRule . I'm fairly sure that's not thread safe. I think you'll need to annotate the test as @NotThreadSafe .

          Karl Shultz added a comment -

          Failures look like this:

          [ERROR] Failures: 
[ERROR] org.jenkinsci.plugins.pubsub.MessageOriginIdentityTest.test(org.jenkinsci.plugins.pubsub.MessageOriginIdentityTest)
[ERROR]   Run 1: MessageOriginIdentityTest.test:84 expected:<http://localhost:35545/jenkins/> but was:<null>
[ERROR]   Run 2: MessageOriginIdentityTest.test:84 expected:<http://localhost:38087/jenkins/> but was:<null>
[ERROR]   Run 3: MessageOriginIdentityTest.test:84 expected:<http://localhost:34253/jenkins/> but was:<null>
[ERROR]   Run 4: MessageOriginIdentityTest.test:84 expected:<http://localhost:45589/jenkins/> but was:<null>
[ERROR]   Run 5: MessageOriginIdentityTest.test:84 expected:<http://localhost:37417/jenkins/> but was:<null>

          We're ending up here, it turns out. Jenkins is null when this test runs.

          Karl Shultz added a comment - Failures look like this: [ERROR] Failures: [ERROR] org.jenkinsci.plugins.pubsub.MessageOriginIdentityTest.test(org.jenkinsci.plugins.pubsub.MessageOriginIdentityTest) [ERROR] Run 1: MessageOriginIdentityTest.test:84 expected:<http://localhost:35545/jenkins/> but was:<null> [ERROR] Run 2: MessageOriginIdentityTest.test:84 expected:<http://localhost:38087/jenkins/> but was:<null> [ERROR] Run 3: MessageOriginIdentityTest.test:84 expected:<http://localhost:34253/jenkins/> but was:<null> [ERROR] Run 4: MessageOriginIdentityTest.test:84 expected:<http://localhost:45589/jenkins/> but was:<null> [ERROR] Run 5: MessageOriginIdentityTest.test:84 expected:<http://localhost:37417/jenkins/> but was:<null> We're ending up here , it turns out. Jenkins is null when this test runs.

          Karl Shultz added a comment -

          tfennelly, if you could take a look at this, I'd really appreciate it. I suspect this is something you could figure out really quickly. I've got a fork/branch with the parent pom update already done, if you want to check that out.

          Karl Shultz added a comment - tfennelly , if you could take a look at this, I'd really appreciate it. I suspect this is something you could figure out really quickly. I've got a fork/branch with the parent pom update already done , if you want to check that out.

            tfennelly Tom FENNELLY
            kshultz Karl Shultz
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: