Status: Resolved (View Workflow)
While debugging the shelve plugin I noticed that the tar function available in the FilePath class is not conserving the symlinks anymore. The shelve plugin is calling the archive function in FilePath:
archive(final ArchiverFactory factory, OutputStream os, final DirScanner scanner) // factory use is TarArchiverFactory with no compression
Both tar archiving function do not properly handle the symlinks to directory (but it works correctly for symlinks to files):
* public int tar(OutputStream out, final String glob) -> uses a DirScanner.Glob (ant style FileSets) that follows the symlink, therefore creates a brand new directory in place of the symlink, not what we want for a tar archive.
* public int tar(OutputStream out, FileFilter filter) -> uses a FileFilter wrapper which for some reasons doesn't redirect the symlink calls to the wrapped FileFilter
Why this is important: this issue has been here for long, but a change made on 2.91 (see my comment below for Issue 2), made this appear more clearly.
- is duplicated by
JENKINS-54998 Stash and archive should refuse symlinks
- relates to
JENKINS-37862 Extract build symlink handling to a plugin
- links to
brianjmurrell Review is stalled, the changes are a bit touchy and would need to be reviewed/discussed with more people. PR is linked to the ticket: https://github.com/jenkinsci/jenkins/pull/3569
As discussed in the associated PR this work will be superseded by https://issues.jenkins-ci.org/browse/JENKINS-37862.
pierrebtz the Shelve plugin could probably work around this issue by excluding known symlink filenames from its patternset.
jglick you're right. Added this in the plugin: https://github.com/jenkinsci/shelve-project-plugin/pull/19
This seems to have been In Review for for 5 months now. Is it really in review or is it stalled for some reason? Where is the PR?