-
Bug
-
Resolution: Fixed
-
Major
-
None
After upgrading badge-plugin to 1.5, the text on existing summary badges is not displayed. For example, in the attached image, all text next to the green checkmark icon is missing.
After rolling back to 1.4, text shows back up.
This appears to affect past summaries badges created with postbuild-groovy as well as newer ones created with badge-plugin. In both cases, badges were created using pipeline shared libs to attach badges to a build which is related to the current build. Here is a related snippet from the pipeline code:
BadgeSummaryAction summary = new BadgeSummaryAction("images/48x48/${summaryIcon}") summary.appendText("<a href=\"${linkUrl}\"\">${description}</a> ${actionTime}", false) build.addAction(summary)
Note: I have not attempted to create a badge using 1.5 to see if its text would show up.
Edit 1: Jenkins version 2.134
[JENKINS-52802] BadgeSummaryAction text missing in 1.5
Issue is confirmed on my end – I even see it in the snippet I posted now. There is an additional double-quote in the link tag. It is, indeed, invalid HTML so version 1.5 does not trust it.
Not an bug. (At least not with the plugin 
) Apologies for the false alarm. Recommend updating change-log to reflect this change since that is the first place that admins probably go when they see odd behavior after updating.
Thank you for the hint.
Added the fixed security issue to the changelog in commit https://github.com/jenkinsci/badge-plugin/commit/c2a15fa9e3891db799928402868d99340d240fbb
After rolling back, I now see a security warning about 1.4. Digging a little deeper, I suspect this is related. I am looking closer at the summary text stored in our build.xml file(s) to see if there is anything odd about it. If I find something on my end, I will update this issue appropriately.
Worth noting that the Security fix did not show up in CHANGELOG.md – looking at the related commit, it seems like it is significant enough to warrant a mention there.