Since state is not persistent, this attempt to handle resumed builds is unlikely to work: there will be a new UUID registered, and any service posting back to a URL obtained prior to the restart will just fail.

      There are no functional tests, much less anything using RestartableJenkinsRule, which would be the natural way to reproduce this sort of issue.


      BTW there are also open issues in GitHub which is confusing. One or the other source of issues should be disabled.

          [JENKINS-53321] Test functioning across restarts

          Jesse Glick added a comment -

          If fixed, this would implement one option of JENKINS-27127.

          Jesse Glick added a comment - If fixed, this would implement one option of JENKINS-27127 .

          Jesse Glick added a comment -

          Or maybe it will work because the token is created in one step and then made a persistent part of the state of another?

          Jesse Glick added a comment - Or maybe it will work because the token is created in one step and then made a persistent part of the state of another?

          Alex Earl added a comment -

          jglick I'm pretty new to the RestartableJenkinsRule tests, does this test actually test what you are looking for?

          https://github.com/slide/webhook-step-plugin/blob/JENKINS-53321/src/test/java/org/jenkinsci/plugins/webhookstep/WaitForWebhookRestartTest.java

          Alex Earl added a comment - jglick I'm pretty new to the RestartableJenkinsRule tests, does this test actually test what you are looking for? https://github.com/slide/webhook-step-plugin/blob/JENKINS-53321/src/test/java/org/jenkinsci/plugins/webhookstep/WaitForWebhookRestartTest.java

          Jesse Glick added a comment -

          Yes that looks right. Assign to yourself and mark In Progress?

          Jesse Glick added a comment - Yes that looks right. Assign to yourself and mark In Progress ?

          Alex Earl added a comment -

          Alex Earl added a comment - Fixed via https://github.com/jenkinsci/webhook-step-plugin/pull/19

            slide_o_mix Alex Earl
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: