-
Improvement
-
Resolution: Won't Do
-
Minor
-
-
Evergreen - Milestone 2
Problem statement
The Evergreen-client class snapshotter.js is tested indirectly, we should test the core git() function more directly and this is the core and most critical part of this class.
Expected behavior
Acceptance criterion: the code coverage should be higher.
To check/get started on this,
- clone https://github.com/jenkins-infra/evergreen
- cd distribution/client
- make check
This will generate a coverage directory, open coverage/lcov-report/index.html with your browser to see the coverage obtained.
Make it better, rinse, repeat 
.
[JENKINS-53503] More test coverage for Snapshotter.git()
Ales Blaze
added a comment - But where to get started?
As being a new person here, interested in contributing and improving this stuff, but wait I don't know where to go?
I don't know where to get the files , please navigate me.
Ales Blaze
added a comment - But where to get started?
As being a new person here, interested in contributing and improving this stuff, but wait I don't know where to go?
I don't know where to get the files , please navigate me. ales starting point is https://github.com/jenkins-infra/evergreen
Then this issue is about adding coverage to the https://github.com/jenkins-infra/evergreen/blob/master/distribution/client/src/lib/snapshotter.ts class.
To run tests and coverage on this, clone the repo, then cd to distribution/client, then run make check. That should be a good starting point.
Please come over to our chat at https://gitter.im/jenkins-infra/evergreen to get live help if needed. I'm willing to add docs to help people hack on Evergreen, but as we can't document everything, I need to understand what are the biggest pains.
Also, going to rephrase the issue description here a bit so that it's a bit more complete for outsiders.
Thanks
I was most interested in testing some of the error branches in git() fwi