Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-53608

Fix up incorrect method signatures on readResolve

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None

      readResolve() should be ANY_ACCESS_MODIFIER Object readResolve() however there are a few uses in class where this is not the case.

      These should be tidied up and fixed.

      hudson/triggers/SCMTrigger.java:        private void readResolve() {
      jenkins/security/apitoken/ApiTokenStats.java:    private ApiTokenStats readResolve() {
      jenkins/security/apitoken/ApiTokenStats.java:        private SingleTokenStats readResolve() {
      

          [JENKINS-53608] Fix up incorrect method signatures on readResolve

          I am hesitant to backport this as it does not address any customer issue while being potentially risky.

          Oliver Gondža added a comment - I am hesitant to backport this as it does not address any customer issue while being potentially risky.

          James Nord added a comment -

          danielbeck requested the backport. I as the reporter personally have no need of one. The only thing I can think may be impacted is if a user has set 1000000 as the SCM threads and that the `readResolve` does not kick in there to limit it to {{MAX_SCM_THREAD}}s.  But that can be fixed without a code change if the user hits the issue (that may not even be an issue)

          James Nord added a comment - danielbeck requested the backport. I as the reporter personally have no need of one. The only thing I can think may be impacted is if a user has set 1000000 as the SCM threads and that the ` readResolve ` does not kick in there to limit it to {{MAX_SCM_THREAD}}s.  But that can be fixed without a code change if the user hits the issue (that may not even be an issue)

          Daniel Beck added a comment -

          Agreed.

          Daniel Beck added a comment - Agreed.

            Unassigned Unassigned
            teilo James Nord
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: