Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5420

Password parameters are stored as plain text in jobs' config and builds' history (patch provided)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Critical
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      Password parameters are stored as plain text in jobs' config and builds' history. They are accessible in:

      • <job>/config.xml
      • <job>/builds/<date>/build.xml

      Cf. attached patches to fix that:

      • PasswordParameterDefinition now inherits from SimpleParameterDefinition rather than StringParameterDefinition and uses a Secret to store the default password rather than a string.
      • PasswordParameterValue now inherits from ParameterValue rather than StringParameterValue and uses Secret to store the password rather than a string.
      • Backward compatibility kept.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : kohsuke
          Path:
          trunk/hudson/main/core/src/main/java/hudson/model/PasswordParameterDefinition.java
          trunk/hudson/main/core/src/main/java/hudson/model/PasswordParameterValue.java
          trunk/www/changelog.html
          http://jenkins-ci.org/commit/26736
          Log:
          [FIXED JENKINS-5420] in 1.344 Password parameter on the disk should be encrypted.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : kohsuke Path: trunk/hudson/main/core/src/main/java/hudson/model/PasswordParameterDefinition.java trunk/hudson/main/core/src/main/java/hudson/model/PasswordParameterValue.java trunk/www/changelog.html http://jenkins-ci.org/commit/26736 Log: [FIXED JENKINS-5420] in 1.344 Password parameter on the disk should be encrypted.

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            rseguy Romain Seguy
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: