Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-54545

Promisify the plugin deletion

    XMLWordPrintable

Details

    • Evergreen - Milestone 2

    Description

      In the storage.ts class, our code to remove plugins (exploded directories and files) is using old-school unlink and remove with callbacks and the likes.

      We should "promisify" it to make it more readable and consistent with the rest of the codebase using Promises.

      See:

      Main pointers about NodeJS's util.promisify:

      Attachments

        Issue Links

          blocks

          Task - A task that needs to be done. JENKINS-54207 Update delete plugin flow to error out for anything other than file not found

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          links to

          Web Link PR

          Activity

            Ascending order - Click to sort in descending order
            jennyfive Jen Lijó added a comment - - edited

            Hi batmat! I would like to give a try to this particular one. I have a year of experience developing in Java / Node and have roughly used Jenkins to run e2e tests, I'd like to get more familiar with the whole Jenkins ecosystem, so I thought contributing would be a good idea  Is Evergreen a good point to start for a beginner? Cheers!

            jennyfive Jen Lijó added a comment - - edited Hi batmat ! I would like to give a try to this particular one. I have a year of experience developing in Java / Node and have roughly used Jenkins to run e2e tests, I'd like to get more familiar with the whole Jenkins ecosystem, so I thought contributing would be a good idea  Is Evergreen a good point to start for a beginner? Cheers!
            batmat Baptiste Mathus added a comment -

            Merged a few minutes ago \o/ Thanks Jen

            batmat Baptiste Mathus added a comment - Merged a few minutes ago \o/ Thanks Jen

            People

              jennyfive Jen Lijó
              batmat Baptiste Mathus
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: