Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-54545

Promisify the plugin deletion

XMLWordPrintable

    • Evergreen - Milestone 2

      In the storage.ts class, our code to remove plugins (exploded directories and files) is using old-school unlink and remove with callbacks and the likes.

      We should "promisify" it to make it more readable and consistent with the rest of the codebase using Promises.

      See:

      Main pointers about NodeJS's util.promisify:

          [JENKINS-54545] Promisify the plugin deletion

          Baptiste Mathus created issue -
          Baptiste Mathus made changes -
          Labels Original: evergreen technical-debt New: evergreen newbie-friendly technical-debt
          Baptiste Mathus made changes -
          Description Original: In the storage.ts class, our code to remove plugins (exploded directories and files) is using old-school {{unlink}} and {{remove}} with callbacks and the likes.

          We should "promisify" it to make it more readable and consistent with the rest of the codebase using Promises.

          See:
          * http://2ality.com/2017/05/util-promisify.html
          * http://2ality.com/2017/05/util-promisify.html           		New: In the storage.ts class, our code to remove plugins (exploded directories and files) is using old-school {{unlink}} and {{remove}} with callbacks and the likes.

          We should "promisify" it to make it more readable and consistent with the rest of the codebase using Promises.

          See:
          * the class to modify https://github.com/jenkins-infra/evergreen/blob/master/distribution/client/src/lib/storage.ts

          Main pointers about NodeJS's {{util.promisify}}:
          * http://2ality.com/2017/05/util-promisify.html
          * http://2ality.com/2017/05/util-promisify.html
          Baptiste Mathus made changes -
          Link New: This issue blocks JENKINS-54207 [ JENKINS-54207 ]
          Jen Lijó made changes -
          Assignee New: Jen Lijó [ jennyfive ]
          Jen Lijó made changes -
          Assignee Original: Jen Lijó [ jennyfive ] New: Baptiste Mathus [ batmat ]
          Baptiste Mathus made changes -
          Assignee Original: Baptiste Mathus [ batmat ]
          Jen Lijó made changes -
          Assignee New: Jen Lijó [ jennyfive ]
          Jen Lijó made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Baptiste Mathus made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Baptiste Mathus made changes -
          Remote Link New: This issue links to "PR (Web Link)" [ 22085 ]

            jennyfive Jen Lijó
            batmat Baptiste Mathus
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: