• Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Minor Minor
    • logstash-plugin
    • None

      The TimeInQueueAction action provides a few properties:

      blockedDurationMillis 0
      blockedTimeMillis 0
      buildableDurationMillis 0
      buildableTimeMillis 500
      buildingDurationMillis  1080061
      executingTimeMillis 3920658
      executorUtilization 3.63
      queuingDurationMillis 3
      queuingTimeMillis 521
      subTaskCount  5
      totalDurationMillis 1080064
      waitingDurationMillis 0
      waitingTimeMillis 0
      

      It would be nice if we could send some of these properties. The easy way could be do do something akin to:

      {
        "data":{
          ...
          "queue" : {
            "blockedDurationMillis": 0,
            "blockedTimeMillis": 0,
            "buildableDurationMillis": 0,
            "buildableTimeMillis": 500,
            "buildingDurationMillis": 1080061,
            "executingTimeMillis": 3920658,
            "executorUtilization": 3.63,
            "queuingDurationMillis": 3,
            "queuingTimeMillis": 521,
            "subTaskCount": 5,
            "totalDurationMillis": 1080064,
            "waitingDurationMillis": 0,
            "waitingTimeMillis": 0
          }
        }
      }
      

          [JENKINS-54645] Send queue data in JSON Payload

          Mike Delaney added a comment -

          If the proposed JSON format is acceptable, I'd be happy to make the change(s) needed to support it.

          Mike Delaney added a comment - If the proposed JSON format is acceptable, I'd be happy to make the change(s) needed to support it.

          Hi, and thanks for the request.
          I understand the need, but for now I wouldn't want to add more data to the requests.

          We have a long running PR to allow customizing the payload via groovy: https://github.com/jenkinsci/logstash-plugin/pull/71
          I would prefer to focus on getting that working, and later make sure that Action data is accessible.

          Alternatively we could just expose another configuration option for this, like in here: https://github.com/jenkinsci/logstash-plugin/pull/80#issuecomment-411343182

          Jakub Bochenski added a comment - Hi, and thanks for the request. I understand the need, but for now I wouldn't want to add more data to the requests. We have a long running PR to allow customizing the payload via groovy: https://github.com/jenkinsci/logstash-plugin/pull/71 I would prefer to focus on getting that working, and later make sure that Action data is accessible. Alternatively we could just expose another configuration option for this, like in here: https://github.com/jenkinsci/logstash-plugin/pull/80#issuecomment-411343182

          Mike Delaney added a comment -

          jbochenski fair enough, is the ideal that we'd be able to set a global level, or project, or both?

          Mike Delaney added a comment - jbochenski fair enough, is the ideal that we'd be able to set a global level, or project, or both?

          Markus Winter added a comment -

          I think there are more and more requests for custom data. That would justify that we introduce something like a data provider as an extension point. This way others can easily extend by implementing the extension point in an own plugin. Precondition would be JENKINS-54685 I think.

          Markus Winter added a comment - I think there are more and more requests for custom data. That would justify that we introduce something like a data provider as an extension point. This way others can easily extend by implementing the extension point in an own plugin. Precondition would be JENKINS-54685 I think.

          Jakub Bochenski added a comment - - edited

          mwinter69 I like the idea of having an extension point for adding extra data. This should allow people to opt-in for the extra data without having to add a ton of switches to the main plugin

          > Precondition would be JENKINS-54685 I think.

          I don't think it's a blocker. Actually maybe it would make sense to have an extension point that could filter/transform the data – then implement JENKINS-54685 as an EP.

          Jakub Bochenski added a comment - - edited mwinter69 I like the idea of having an extension point for adding extra data. This should allow people to opt-in for the extra data without having to add a ton of switches to the main plugin > Precondition would be JENKINS-54685 I think. I don't think it's a blocker. Actually maybe it would make sense to have an extension point that could filter/transform the data – then implement JENKINS-54685 as an EP.

          mdelaney why did you close the issue as a duplicate? I don't think we have a duplicate ticket for sending the queue data..

          Jakub Bochenski added a comment - mdelaney why did you close the issue as a duplicate? I don't think we have a duplicate ticket for sending the queue data..

            jbochenski Jakub Bochenski
            mdelaney Mike Delaney
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated: