Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-54693

Improve doCheckUpdatesServer: logs, internal logic

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Minor Minor
    • core

      During the review process of the pull request #3718 addressing the JENKINS-54459 issue, oleg_nenashev suggested:

      • Change the log messages to gain better performance, removing the previous-to-call formatting and the internationalization
      • Change the internal logic, use AperiodicWork rather than sleep
      • Restrict the type of exception raised to a ExecutionException

      This task addresses these changes

          [JENKINS-54693] Improve doCheckUpdatesServer: logs, internal logic

          Ramon Leon created issue -
          Ramon Leon made changes -
          Description Original: Avoid showing the angry Jenkins with all the stack trace when a problem happens checking the update sites. It's common (unfortunately) that update site returns a 502 error code, so it's interesting to avoid showing the Angry Jenkins and all the stack trace.

          Also a mechanism to retry several times before raising an error will be helpful.
          New: During the review process of the pull request addressing the CORE-284 issue, [~onenashev] suggested:

          * Change the log messages to gain better performance, removing the previous-to-call formatting and the internationalization
          * Change the internal logic, use _AperiodicWork_ rather than sleep
          * Restrict the type of exception raised to a [ExecutionException|https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ExecutionException.html]

          This task addresses these changes
          Ramon Leon made changes -
          Description Original: During the review process of the pull request addressing the CORE-284 issue, [~onenashev] suggested:

          * Change the log messages to gain better performance, removing the previous-to-call formatting and the internationalization
          * Change the internal logic, use _AperiodicWork_ rather than sleep
          * Restrict the type of exception raised to a [ExecutionException|https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ExecutionException.html]

          This task addresses these changes
          New: During the review process of the pull request addressing the JENKINS-54459 issue, [~onenashev] suggested:
           * Change the log messages to gain better performance, removing the previous-to-call formatting and the internationalization
           * Change the internal logic, use _AperiodicWork_ rather than sleep
           * Restrict the type of exception raised to a [ExecutionException|https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ExecutionException.html]

          This task addresses these changes
          Ramon Leon made changes -
          Description Original: During the review process of the pull request addressing the JENKINS-54459 issue, [~onenashev] suggested:
           * Change the log messages to gain better performance, removing the previous-to-call formatting and the internationalization
           * Change the internal logic, use _AperiodicWork_ rather than sleep
           * Restrict the type of exception raised to a [ExecutionException|https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ExecutionException.html]

          This task addresses these changes
          New: During the review process of the [pull request |[http://example.com|https://github.com/jenkinsci/jenkins/pull/3718]]addressing the JENKINS-54459 issue, [~onenashev] suggested:
           * Change the log messages to gain better performance, removing the previous-to-call formatting and the internationalization
           * Change the internal logic, use _AperiodicWork_ rather than sleep
           * Restrict the type of exception raised to a [ExecutionException|https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ExecutionException.html]

          This task addresses these changes
          Ramon Leon made changes -
          Description Original: During the review process of the [pull request |[http://example.com|https://github.com/jenkinsci/jenkins/pull/3718]]addressing the JENKINS-54459 issue, [~onenashev] suggested:
           * Change the log messages to gain better performance, removing the previous-to-call formatting and the internationalization
           * Change the internal logic, use _AperiodicWork_ rather than sleep
           * Restrict the type of exception raised to a [ExecutionException|https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ExecutionException.html]

          This task addresses these changes
          New: During the review process of the [pull request |https://github.com/jenkinsci/jenkins/pull/3718]addressing the JENKINS-54459 issue, [~onenashev] suggested:
           * Change the log messages to gain better performance, removing the previous-to-call formatting and the internationalization
           * Change the internal logic, use _AperiodicWork_ rather than sleep
           * Restrict the type of exception raised to a [ExecutionException|https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ExecutionException.html]

          This task addresses these changes
          Ramon Leon made changes -
          Description Original: During the review process of the [pull request |https://github.com/jenkinsci/jenkins/pull/3718]addressing the JENKINS-54459 issue, [~onenashev] suggested:
           * Change the log messages to gain better performance, removing the previous-to-call formatting and the internationalization
           * Change the internal logic, use _AperiodicWork_ rather than sleep
           * Restrict the type of exception raised to a [ExecutionException|https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ExecutionException.html]

          This task addresses these changes
          New: During the review process of the [pull request #3718 |https://github.com/jenkinsci/jenkins/pull/3718]addressing the JENKINS-54459 issue, [~onenashev] suggested:
           * Change the log messages to gain better performance, removing the previous-to-call formatting and the internationalization
           * Change the internal logic, use _AperiodicWork_ rather than sleep
           * Restrict the type of exception raised to a [ExecutionException|https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ExecutionException.html]

          This task addresses these changes
          Ramon Leon made changes -
          Description Original: During the review process of the [pull request #3718 |https://github.com/jenkinsci/jenkins/pull/3718]addressing the JENKINS-54459 issue, [~onenashev] suggested:
           * Change the log messages to gain better performance, removing the previous-to-call formatting and the internationalization
           * Change the internal logic, use _AperiodicWork_ rather than sleep
           * Restrict the type of exception raised to a [ExecutionException|https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ExecutionException.html]

          This task addresses these changes
          New: During the review process of the [pull request #3718 |https://github.com/jenkinsci/jenkins/pull/3718]addressing the JENKINS-54459 issue, [~oleg_nenashev] suggested:
           * Change the log messages to gain better performance, removing the previous-to-call formatting and the internationalization
           * Change the internal logic, use _AperiodicWork_ rather than sleep
           * Restrict the type of exception raised to a [ExecutionException|https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ExecutionException.html]

          This task addresses these changes

          Ramon Leon added a comment -

          Follow-up

          Ramon Leon added a comment - Follow-up
          Ramon Leon made changes -
          Link New: This issue is related to JENKINS-54459 [ JENKINS-54459 ]

            mramonleon Ramon Leon
            mramonleon Ramon Leon
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: