-
Task
-
Resolution: Fixed
-
Minor
-
None
-
-
Evergreen - Milestone 2
Problem statement
We enabled some time ago the fact that reviews were required.
In the go, we also enabled the fact that the branch *must* be up-to-date.
This makes sense in general, but is mostly a waste of time in our time, given we use the merge strategy, i.e. Jenkins will first merge the PR against master, then build it (showing up as pr-merge on the PR status check).
I assume this GitHub settings makes sense for other CI systems or when Jenkins is only configured to build the so-called pr-head.
Expected
We should only require reviews.
We can allow not being up to date with master branch given we build pr-merge.
to clarify, we need to uncheck the bolded line: