Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-54904

"(hide)" and "(show)" links in console broken in Firefox

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • workflow-job-plugin
    • None
    • Jenkins core 2.153
      workflow-job 2.29
      (latest versions of all installed plugins like pipeline as of 27.11.2018)
    • workflow-job 2.30

      From JENKINS-41845

      The recently ("introduced in workflow-job 2.26") added ability to collapse sections with "(hide)" links in console view of classic UI does not work:

      1. Initial

      2. After clicking on "(hide)" link

      Unless I don't understand the feature? I expected that the "(hide)" links (that only appear via mouse over) allow to collapse the corresponding "nodes", and "(show)" links re-expand them? (In the screenshots above therefore the text "Build (#95): 20181127-093111-revUNKNOWN".

        1. image-2018-11-28-08-54-09-850.png
          image-2018-11-28-08-54-09-850.png
          3 kB
        2. image-2018-11-28-08-54-42-774.png
          image-2018-11-28-08-54-42-774.png
          3 kB

          [JENKINS-54904] "(hide)" and "(show)" links in console broken in Firefox

          Jesse Glick added a comment -

          Working for me last I checked. Perhaps certain scripts do not work this way, or perhaps it does not work on certain browsers, or perhaps there are some errors in your browser console.

          Jesse Glick added a comment - Working for me last I checked. Perhaps certain scripts do not work this way, or perhaps it does not work on certain browsers, or perhaps there are some errors in your browser console.

          Reinhold Füreder added a comment -

          Sorry for my incomplete report and congrats to your great intuition:

          • Firefox 63.0.3
          • Browser console shows this error: 
            TypeError: ss.rules is undefined[Weitere Informationen] 5 script.js:37:25
	showHide https://jenkins.acme.com/static/cf22a270/descriptor/org.jenkinsci.plugins.workflow.job.console.NewNodeConsoleNote/script.js:37:25
	showHidePipelineSection https://jenkins.acme.com/static/cf22a270/descriptor/org.jenkinsci.plugins.workflow.job.console.NewNodeConsoleNote/script.js:45:5
	onclick https://jenkins.acme.com/job/Sandbox/job/acme.stage/95/console:1:1

          Reinhold Füreder added a comment - Sorry for my incomplete report and congrats to your great intuition: Firefox 63.0.3 Browser console shows this error: TypeError: ss.rules is undefined[Weitere Informationen] 5 script.js:37:25 showHide https: //jenkins.acme.com/ static /cf22a270/descriptor/org.jenkinsci.plugins.workflow.job.console.NewNodeConsoleNote/script.js:37:25 showHidePipelineSection https: //jenkins.acme.com/ static /cf22a270/descriptor/org.jenkinsci.plugins.workflow.job.console.NewNodeConsoleNote/script.js:45:5 onclick https: //jenkins.acme.com/job/Sandbox/job/acme.stage/95/console:1:1

          Jesse Glick added a comment -

          OK, not sure yet if I will be able to reproduce that, but looks easy enough to fix.

          Jesse Glick added a comment - OK, not sure yet if I will be able to reproduce that, but looks easy enough to fix.

          Jesse Glick added a comment -

          Indeed it did not work in Firefox.

          Jesse Glick added a comment - Indeed it did not work in Firefox.

          Jesse Glick added a comment -

          If you could try the “incremental” build from that PR and confirm it works, I would appreciate it.

          Jesse Glick added a comment - If you could try the “incremental” build from that PR and confirm it works, I would appreciate it.

          Reinhold Füreder added a comment -

          Thanks for the quick fix: yes, it works as expected

          Reinhold Füreder added a comment - Thanks for the quick fix: yes, it works as expected

          Devin Nusbaum added a comment -

          This should be fixed in version 2.30 of the Pipeline Job Plugin, which was just released.

          Devin Nusbaum added a comment - This should be fixed in version 2.30 of the Pipeline Job Plugin, which was just released.

            jglick Jesse Glick
            reinholdfuereder Reinhold Füreder
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: