Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-55953

JCasC compability with RocketChat Notifier Plugin

XMLWordPrintable

      RocketChat Notifier Plugin should be configurable via JCasC compability
      (see https://github.com/jenkinsci/configuration-as-code-plugin/blob/master/docs/REQUIREMENTS.md)

          [JENKINS-55953] JCasC compability with RocketChat Notifier Plugin

          Uwe Hanisch added a comment -

          First try according to https://github.com/jenkinsci/configuration-as-code-plugin/blob/master/docs/REQUIREMENTS.md
          see:

          Problem:

          • Configuration via JCasC works fine, but via GUI / Configure Jenkins doesn't work anymore (changes are not saved)
          • needed to rename parameter in jelly and RocketChatNotifier#DescriptorImpl so set getter/setter correspond to property name
          • better use RocketJobProperty?

          Uwe Hanisch added a comment - First try according to https://github.com/jenkinsci/configuration-as-code-plugin/blob/master/docs/REQUIREMENTS.md see: Branch: https://github.com/uhanisch/rocketchatnotifier-plugin/tree/JENKINS-55953-JCasC-compatibility Commit: https://github.com/uhanisch/rocketchatnotifier-plugin/commit/78080e45ba39dac8df2b12c921a67075c99ab367 Problem: Configuration via JCasC works fine, but via GUI / Configure Jenkins doesn't work anymore (changes are not saved) needed to rename parameter in jelly and RocketChatNotifier#DescriptorImpl so set getter/setter correspond to property name better use RocketJobProperty?

          Martin Reinhardt added a comment -

          have to look after it, but currently don't have much time for this and never uses JCasC.

          Martin Reinhardt added a comment - have to look after it, but currently don't have much time for this and never uses JCasC.

          Martin Reinhardt added a comment -

          merged your changes on a new feature branch and fixed smaller issues: https://github.com/jenkinsci/rocketchatnotifier-plugin/tree/feature/JCasC-compatibility

          But still the saving error occurs. asked via gitter for help

          Martin Reinhardt added a comment - merged your changes on a new feature branch and fixed smaller issues: https://github.com/jenkinsci/rocketchatnotifier-plugin/tree/feature/JCasC-compatibility But still the saving error occurs. asked via gitter for help

          Wojciech Sciesinski added a comment -

          Any updated? Thank you.

          Wojciech Sciesinski added a comment - Any updated? Thank you.

          Martin Reinhardt added a comment -

          nope, didn't had time for this as it requires more changes.

          Martin Reinhardt added a comment - nope, didn't had time for this as it requires more changes.

          Martin Reinhardt added a comment -

          Readded the changes on develop. Looking forward that CI passes: https://travis-ci.org/jenkinsci/rocketchatnotifier-plugin/builds/582778920

          Martin Reinhardt added a comment - Readded the changes on develop. Looking forward that CI passes: https://travis-ci.org/jenkinsci/rocketchatnotifier-plugin/builds/582778920

          Martin Reinhardt added a comment -

          Could you give version 1.4.6 a try?

          Martin Reinhardt added a comment - Could you give version 1.4.6 a try?

            uhanisch Uwe Hanisch
            uhanisch Uwe Hanisch
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated: