Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5610

be able to do 'doCheckXXX' for forms with multiple parameters

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • None
    • None

      E.g. in the EC2 plugin the 'endpoint url' field can only be reliably validated using the accesskey and secretkey, so we would want
      doCheckec2EndpointUrl(@QueryParameter String EndpointUrl, @QueryParameter String accessId, @QueryParameter String secretKey) {
      ...
      }

          [JENKINS-5610] be able to do 'doCheckXXX' for forms with multiple parameters

          Attack plan:

          • Descriptor.doCheckUrl needs to look at the signature of the check method to determine what parameters need to be sent back. Need to think about how this works, given the existing behavior of passing in the current value as "value". Perhaps a new annotation is in order?
          • A little bit of client-side JavaScript addition to discover nearby fields of the specified name, that properly incorporates the tree structure boundary.

          Kohsuke Kawaguchi added a comment - Attack plan: Descriptor.doCheckUrl needs to look at the signature of the check method to determine what parameters need to be sent back. Need to think about how this works, given the existing behavior of passing in the current value as "value". Perhaps a new annotation is in order? A little bit of client-side JavaScript addition to discover nearby fields of the specified name, that properly incorporates the tree structure boundary.

          Code changed in hudson
          User: : kohsuke
          Path:
          trunk/hudson/main/core/pom.xml
          trunk/hudson/main/core/src/main/java/hudson/model/Descriptor.java
          trunk/hudson/main/war/resources/scripts/hudson-behavior.js
          trunk/www/changelog.html
          http://jenkins-ci.org/commit/27436
          Log:
          [FIXED JENKINS-5610] Improved the form validation mechanism to support multiple controls.

          SCM/JIRA link daemon added a comment - Code changed in hudson User: : kohsuke Path: trunk/hudson/main/core/pom.xml trunk/hudson/main/core/src/main/java/hudson/model/Descriptor.java trunk/hudson/main/war/resources/scripts/hudson-behavior.js trunk/www/changelog.html http://jenkins-ci.org/commit/27436 Log: [FIXED JENKINS-5610] Improved the form validation mechanism to support multiple controls.

          Alan Harder added a comment -

          All form field validators and form submissions are now failing in trunk.

          Alan Harder added a comment - All form field validators and form submissions are now failing in trunk.

          I believe it was caused by the failed stapler release and is now fixed.

          Kohsuke Kawaguchi added a comment - I believe it was caused by the failed stapler release and is now fixed.

            kohsuke Kohsuke Kawaguchi
            lifeless lifeless
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: