• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None
    • Jenkins 2.214

      I intentionally deleted the mailer plugin (the reasons are immaterial)

      Dependency errors:

      Some plugins could not be loaded due to unsatisfied dependencies. Fix these issues and restart Jenkins to restore the functionality provided by these plugins.

      Lockable Resources plugin version 2.4

          mailer version 1.5 is missing. To fix, install version 1.5 or later.

      Pipeline: Basic Steps version 2.14

          mailer version 1.18 is missing. To fix, install version 1.18 or later.

      Downstream dependency errors:

      These plugins failed to load because of one or more of the errors above. Fix those and these plugins will load again.

      Docker Pipeline version 1.17

          Pipeline: Basic Steps version 2.14 failed to load. Fix this plugin first.

      Hubot Pipeline Steps version 2.0.3

          Pipeline version 2.6 failed to load. Fix this plugin first.

      Pipeline version 2.6

          Lockable Resources plugin version 2.4 failed to load. Fix this plugin first.

      Pipeline: Declarative version 1.3.4.1

          Pipeline: Basic Steps version 2.14 failed to load. Fix this plugin first.

      Perhaps, most importantly, the Correct button doesn't do what one would expect. – It takes one to /pluginManager/ which is:

      1. The wrong screen
        1. It should be /pluginManager/available
        2. This should be done.
      2. The relevant plugins aren't selected
      3. The simplest fix would be to change the button label from Correct to Manage 
      4. The better fix would be to preselect the missing plugins.
      5. After installing the plugin (which doesn't require a restart), the dependencies aren't recalculated.

      The layout of this is more or less:

      1. Heading:
      2. Descriptive message which is not actually covered by heading, but merely explains the heading
      3. Actual items related to heading.

      I think the basic fix is changing the order to roughly:

      1. Descriptive message
      2. Heading:
      3. Actual items

      Beyond the most basic:

      • The use of bold is really unhelpful.
        • Plugin names should be consistently styled in all 4 sections
        • The version field should not be styled in the same way.
      • I don't think that "Fix this plugin first" adds any value.
      • I don't think that the label "Downstream dependency errors" is particularly helpful – a label is needed, but it should be something else.

      Note:

      Below this blob is:

      New version of Jenkins (2.164) is available for download (changelog).

      The version formatting style here is better than the one used above.

       

          [JENKINS-56152] Improve dependency errors message

          Josh Soref added a comment - - edited

          Josh Soref added a comment - - edited https://github.com/jenkinsci/jenkins/pull/3904

          Josh Soref added a comment -

          This is w/ my updated message, but I want to discuss an edge:

          Some plugins could not be loaded due to unsatisfied dependencies. Fix these issues and restart Jenkins to reenable these plugins.
          
          Dependency errors:
          Pipeline (2.6)
            Disabled: Pipeline: Shared Groovy Libraries
            ...
            Disabled: Pipeline: Basic Steps
          ...
          
          Some of the above failures also result in additional indirectly dependent plugins not being able to load.
          
          Indirectly dependent plugins:
          ...
          Pipeline (2.6)
            Failed to load: Pipeline: Nodes and Processes (2.29)

          If Pipeline has top level dependency errors, is it really useful to list indirect dependency errors as well?

          Personally, I think I'd rather fold dependencies into the main list as just a single line item:
          {{Dependent:

          {name}

          }}.

          I'm open to suggestions. I might not make this change in this bug/pr series.

          Josh Soref added a comment - This is w/ my updated message, but I want to discuss an edge: Some plugins could not be loaded due to unsatisfied dependencies. Fix these issues and restart Jenkins to reenable these plugins. Dependency errors: Pipeline (2.6) Disabled: Pipeline: Shared Groovy Libraries ... Disabled: Pipeline: Basic Steps ... Some of the above failures also result in additional indirectly dependent plugins not being able to load. Indirectly dependent plugins: ... Pipeline (2.6) Failed to load: Pipeline: Nodes and Processes (2.29) If Pipeline has top level dependency errors, is it really useful to list indirect dependency errors as well? Personally, I think I'd rather fold dependencies into the main list as just a single line item: {{Dependent: {name} }}. I'm open to suggestions. I might not make this change in this bug/pr series.

            jsoref Josh Soref
            jsoref Josh Soref
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: