Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-57378

warnings-ng commands show up as General Build Step in pipeline views

      At least the recordIssues command in a pipeline shows up as "General Build Step" when looking at the "Pipeline Steps" in the build details of a job.

      Moreover, the arguments of the step are not shown in the UI.

          [JENKINS-57378] warnings-ng commands show up as General Build Step in pipeline views

          Ulli Hafner added a comment -

          Ok, I'm closing it. If you see it a again please reopen and provide a pointer to the wrong message.

          Ulli Hafner added a comment - Ok, I'm closing it. If you see it a again please reopen and provide a pointer to the wrong message.

          Jason Faust added a comment - - edited

          Just had it pop up again.

          Using Warnings-NG 5.0.0, analysis-model-api 5.0.2, Jenkins 2.164.3, and all the other plugins patched up to the version as of writing this note.

          Note, had just did an inplace restart of Jenkins to patch analysis-model-api

          But the output of the stage where I had all the static analysis bits in it looks like:

          Stage : Start - (2 min 2 sec in block)	Static Analysis	Console Output	Success
          Static Analysis - (2 min 2 sec in block)			Success
          General Build Step - (24 sec in self)		Console Output	Success
          General Build Step - (20 sec in self)		Console Output	Success
          General Build Step - (18 sec in self)		Console Output	Success
          General Build Step - (12 sec in self)		Console Output	Success
          General Build Step - (15 sec in self)		Console Output	Success
          General Build Step - (12 sec in self)		Console Output	Success
          General Build Step - (16 sec in self)		Console Output	Success
          

          Jason Faust added a comment - - edited Just had it pop up again. Using Warnings-NG 5.0.0, analysis-model-api 5.0.2, Jenkins 2.164.3, and all the other plugins patched up to the version as of writing this note. Note, had just did an inplace restart of Jenkins to patch analysis-model-api But the output of the stage where I had all the static analysis bits in it looks like: Stage : Start - (2 min 2 sec in block) Static Analysis Console Output Success Static Analysis - (2 min 2 sec in block) Success General Build Step - (24 sec in self) Console Output Success General Build Step - (20 sec in self) Console Output Success General Build Step - (18 sec in self) Console Output Success General Build Step - (12 sec in self) Console Output Success General Build Step - (15 sec in self) Console Output Success General Build Step - (12 sec in self) Console Output Success General Build Step - (16 sec in self) Console Output Success

          Jason Faust added a comment -

          I'll try to track this down better for debugging, but did see it happen again.

          Jason Faust added a comment - I'll try to track this down better for debugging, but did see it happen again.

          Ulli Hafner added a comment -

          I must admit that I'm not really a pipeline user... I still have no clue where your output from above comes from and what are you expecting. Should there be something more specific than "General Build Step"?

          Ulli Hafner added a comment - I must admit that I'm not really a pipeline user... I still have no clue where your output from above comes from and what are you expecting. Should there be something more specific than "General Build Step"?

          Jason Faust added a comment - - edited

          It should be reading (I imagine) Record compiler warnings and static analysis results (for each line, all seven of those are recordIssues commands)

          Jason Faust added a comment - - edited It should be reading (I imagine) Record compiler warnings and static analysis results (for each line, all seven of those are recordIssues commands)

          Jason Faust added a comment -

          I'll work on generating an actual example of the bug, with input files, as soon as I get a chance.

          Jason Faust added a comment - I'll work on generating an actual example of the bug, with input files, as soon as I get a chance.

          Ulli Hafner added a comment -

          I see. It would also make sense to see the actual arguments of the step. I have no idea how to set or change it...

          Ulli Hafner added a comment - I see. It would also make sense to see the actual arguments of the step. I have no idea how to set or change it...

          Ulli Hafner added a comment -

          In order to show the arguments one needs to override argumentsToString in the Descriptor.

          Ulli Hafner added a comment - In order to show the arguments one needs to override argumentsToString in the Descriptor.

          Trying to figure out whether this issue has been fixed:

          • "the arguments of the step are not shown in the UI" was fixed as JENKINS-62415.
          • "General Build Step" doesn't seem to have been explicitly fixed, but I can't reproduce it either. I see "Record compiler warnings and static analysis results" in "Pipeline Steps" when using Jenkins 2.263.3 and Warnings Next Generation Plugin 8.8.0. If I understand correctly, the text comes from io.jenkins.plugins.analysis.core.steps.RecordIssuesStep.Descriptor#getDisplayName(). This issue was said to occur in Warnings-NG 5.0.0, which did not have RecordIssuesStep yet; but that version already had io.jenkins.plugins.analysis.core.steps.IssuesRecorder.Descriptor#getDisplayName() with an identical implementation.

          Kalle Niemitalo added a comment - Trying to figure out whether this issue has been fixed: "the arguments of the step are not shown in the UI" was fixed as JENKINS-62415 . "General Build Step" doesn't seem to have been explicitly fixed, but I can't reproduce it either. I see "Record compiler warnings and static analysis results" in "Pipeline Steps" when using Jenkins 2.263.3 and Warnings Next Generation Plugin 8.8.0. If I understand correctly, the text comes from io.jenkins.plugins.analysis.core.steps.RecordIssuesStep.Descriptor#getDisplayName(). This issue was said to occur in Warnings-NG 5.0.0, which did not have RecordIssuesStep yet; but that version already had io.jenkins.plugins.analysis.core.steps.IssuesRecorder.Descriptor#getDisplayName() with an identical implementation.

          Ulli Hafner added a comment -

          We already discussed (in 2019) that the text "General Build Step" only sometimes occurs. It cannot reproduce that with the latests versions as well. So I think we can close this issue for now.

          Ulli Hafner added a comment - We already discussed (in 2019) that the text "General Build Step" only sometimes occurs. It cannot reproduce that with the latests versions as well. So I think we can close this issue for now.

            Unassigned Unassigned
            jfaust Jason Faust
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: