-
Task
-
Resolution: Fixed
-
Minor
-
-
GSoC 2019. Coding Phase 1
For the GSoC project gitlab-branch-source-plugin the student is requesting a new repo be created titled "gitlab-branch-plugin
Detailed reasoning for this is here:
2) I read the documentation of SCM API and Branch API Plugins to understand the classes needs to be implemented in GitLab Branch Source Plugin. Based on which I prepared the design document. This design document will be improved throughout the course of development. Will add apis, workflow, issues etc to it.
3) I have been studing the codebases of ArgelBargel's GitLab Branch Source Plugin, GitHub Branch Source Plugin and Gitea Plugin. My takeaway was GitLab BS has been implemented in a way that is not very different from the other Branch Source Plugins in terms of the underlying APIs implementation but still exists some differences that cannot be ignored. For example,
i) The class names are different and many code refractories has been done so it creates a difficulty in implementing the same logic while extending the plugin. Like SCMSource has been broken down to other sub classes , SCMHeadCategory has some different implementation, SCMFileSystem is not implemented, APIs implementation also needs to be changed and the list goes on..
ii) The conclusion I have come to is that it would be rather lesser amount of work for me if I had to implement a new GitLab Branch Source Plugin which will be heavily inspired from Gitea Plugin (as suggested by Robert Sandall in mailing list) and also some inspiration will be taken from GitLab Branch Source and GitHub Branch Source Plugins.
iii) I will send my complete list of reasons not to develop the existing GitLab Branch Source Plugin.
[JENKINS-57677] Create new repo for GSoC gitlab-branch-source-plugin
jequals5 I got this. I have already hosted a plugin so I am aware of the procedure. In that case there was also a conflicting plugin name and the older plugin was renamed and archived. You just have to handle this initial part. i.e. discuss with ci_jenkinsci_org to either allow us push access to GitLab Branch Source Plugin or follow the archiving procedure.
After ^this is done, I will proceed with the hosting process accordingly.
baymac oleg_nenashev I think in the interest of time we should just use the current plugin GitHub repo (https://github.com/jenkinsci/gitlab-branch-source-plugin). So we will need to request access to this by becoming the maintainers, is that correct oleg_nenashev and to do so we will need to request that through the jenkins-dev mailing? If so, I fear that the usual time it takes for the to happen can be lengthily, is there something we can do to expedite that faster oleg_nenashev
I have sent an email to the Jenkins-dev mailing list here: https://groups.google.com/forum/#!topic/jenkinsci-dev/k_12IoFRNHg
I don't think hosting our plugin I'm 'jenkinsci' org is an urgent requirement. Although I agree we should start this process early lest it takes time. I will start a new repo on the test org I created for GSoC (I'll add you there) and when our plugin reaches releasable state, we can always fork it into 'jenkinsci' org.
That's a good idea. We can start from design, coding. When we think it's ready. Then fork it.
GitLab Branch Source Plugin has been created here - [#https://github.com/baymac/gitlab-branch-source-plugin]
The repository will also contain server configuration implementation and later moved into a different plugin.
baymac since you created the repo, I would say this task is completed
Okay, we will create a new issue when about to host the plugin. Can you resolve it jequals5?
Please follow the Plugin Hosting process: https://wiki.jenkins.io/display/JENKINS/Hosting+Plugins