Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-57877

PromotionBadge compatibility with pipelines

XMLWordPrintable

    • GSoC 2019. Coding Phase 1, GSoC 2019. Coding Phase 2, GSoC 2019. Coding Phase 3

      [Note]: Pipeline Steps are not incorporated in this task.

      PromotionBadge class is to be made pipeline compatible:

      Required changes during the course:

      • Refactor the PromotionBadge class
      • Make a new interface analogous to Promotion.java
      • Refactor both ManualCondition and GroovyCondition which are the implementations of buildEnvVars
      • There is a "addPromotionBadge()" pipeline step which demonstrates the compatibility
      • There is is a documentation sample which shows how to use the feature in Pipeline

       Acceptance Criteria:

      • Refactor the PromotionBadge class for pipeline compatibility.
      • Changes made to Groovy+Manual Condition for binary compatibility.
      • Changes made to Promotion and Status classes for binary compatibility.
      • Introduction of a new Interface PromotionRun.
      • Add the "AddPromotionBadge" class for checking on-spot.
      • Unit/Compilation Tests before Merge.

          [JENKINS-57877] PromotionBadge compatibility with pipelines

          Prastik Gyawali created issue -
          Prastik Gyawali made changes -
          Epic Link New: JENKINS-57634 [ 199564 ]
          Prastik Gyawali made changes -
          Rank New: Ranked higher
          Prastik Gyawali made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Prastik Gyawali made changes -
          Description Original: PromotionBadge class is to be made pipeline compatible:

          Required changes during the course:
           * Refactor the PromotionBadge class
           * Make a new interface analogous to Promotion.java
           * Refactor both ManualCondition and GroovyCondition which are the implementations of buildEnvVars.           		New: [Note]: Pipeline Steps are not incorporated in this task.

          PromotionBadge class is to be made pipeline compatible:

          Required changes during the course:
           * Refactor the PromotionBadge class
           * Make a new interface analogous to Promotion.java
           * Refactor both ManualCondition and GroovyCondition which are the implementations of buildEnvVars.
          Prastik Gyawali made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Prastik Gyawali made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Resolved [ 5 ]

          Oleg Nenashev added a comment -

          The ticket is marked as resolved, but there was no final implementation suggested in a PR and merged into Promoted Builds. Am I missing something?

          Oleg Nenashev added a comment - The ticket is marked as resolved, but there was no final implementation suggested in a PR and merged into Promoted Builds. Am I missing something?

          Jon Brohauge added a comment - - edited

          Status should not be resolved prior to merge on the relevant PR

          Status set to be in progress, since there is no PR, or other solution presented to resolve this ticket.

          Jon Brohauge added a comment - - edited Status should not be resolved prior to merge on the relevant PR Status set to be in progress, since there is no PR, or other solution presented to resolve this ticket.
          Jon Brohauge made changes -
          Resolution Original: Fixed [ 1 ]
          Status Original: Resolved [ 5 ] New: Reopened [ 4 ]

            oleg_nenashev Oleg Nenashev
            derndren161 Prastik Gyawali
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated: