What should be the artifact id of a Turkish localization plugin?

      According to JEP-216, the artifact id must include the country code (localization-[language code]-[country code]-plugin), but Turkish localization files inside Jenkins do not contain country code (Messages_tr.properties).

      Should I name the artifact as "localization-tr-tr-plugin" and rename all files to "Messages_tr_TR.properties" or is the name "localization-tr-plugin" enough?

          [JENKINS-57919] Naming Turkish localization plugin

          Daniel Beck added a comment -

          TLDR: Use localization-tr.

          JEP-216 is wrong in this regard, and should be changed.

          • First, the -plugin suffix goes against regular plugin naming convention. Even localization-zh-cn does not follow this rule.
          • Secondly, JEP-216 was authored by a contributor from China, where the country code is essential to distinguish Simplified Chinese (China) from Traditional Chinese (Taiwan), so I guess stating that country code is required, even if not useful for the majority of languages, is just a simple oversight.

          Thanks for checking!

          Daniel Beck added a comment - TLDR: Use localization-tr. JEP-216 is wrong in this regard, and should be changed. First, the -plugin suffix goes against regular plugin naming convention. Even localization-zh-cn does not follow this rule. Secondly, JEP-216 was authored by a contributor from China, where the country code is essential to distinguish Simplified Chinese (China) from Traditional Chinese (Taiwan), so I guess stating that country code is required, even if not useful for the majority of languages, is just a simple oversight. Thanks for checking!

          Daniel Beck added a comment -

          (Obviously, if there is a "China" kind of situation for Turkish that I might be unaware of, this changes. But I would still recommend e.g. localization-pt for Portuguese, and localization-pt-br for Brazilian Portuguese, if those were maintained in separate plugins. I expect even if there's a notable variant of Turkish, that "Turkey Turkish" would be the "default" here)

          Daniel Beck added a comment - (Obviously, if there is a "China" kind of situation for Turkish that I might be unaware of, this changes. But I would still recommend e.g. localization-pt for Portuguese, and localization-pt-br for Brazilian Portuguese, if those were maintained in separate plugins. I expect even if there's a notable variant of Turkish, that "Turkey Turkish" would be the "default" here)

          Mustafa Ulu added a comment -

          Thanks for your time. I will use following names:

          Repository: localization-tr-plugin.git

          Artifact: localization-tr.hpi

          Mustafa Ulu added a comment - Thanks for your time. I will use following names: Repository: localization-tr-plugin.git Artifact: localization-tr.hpi

          Mustafa Ulu added a comment -

          I have created a hosting request: https://issues.jenkins-ci.org/browse/HOSTING-783

          Mustafa Ulu added a comment - I have created a hosting request:  https://issues.jenkins-ci.org/browse/HOSTING-783

          Rick added a comment -
          • First, the -plugin suffix goes against regular plugin naming convention. Even localization-zh-cn does not follow this rule.

          I'm not sure I understand this point. You mean the code repo name should be jenkinsci/localization-zh-cn?

           

          And thanks to danielbeck for the explanation.

          Rick added a comment - First, the  -plugin  suffix goes against regular plugin naming convention. Even localization-zh-cn does not follow this rule. I'm not sure I understand this point. You mean the code repo name should be jenkinsci/localization-zh-cn?   And thanks to danielbeck for the explanation.

          Daniel Beck added a comment -

          I'm not sure I understand this point. You mean the code repo name should be jenkinsci/localization-zh-cn?

          The repo is $artifactId-plugin and therefore derived from the artifact ID / plugin name. If you are talking about the repo name in https://github.com/jenkinsci/jep/tree/master/jep/216#plugin-naming rather than plugin name, that is unclear.

          Daniel Beck added a comment - I'm not sure I understand this point. You mean the code repo name should be jenkinsci/localization-zh-cn? The repo is $artifactId-plugin and therefore derived from the artifact ID / plugin name. If you are talking about the repo name in  https://github.com/jenkinsci/jep/tree/master/jep/216#plugin-naming rather than plugin name, that is unclear.

            danielbeck Daniel Beck
            mustafau Mustafa Ulu
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: