Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-58339

Support new types of credentials

    XMLWordPrintable

    Details

    • Similar Issues:
    • Released As:
      0.1.0

      Description

      Hello!

      I've created a [fork|https://github.com/Quaiks/aws-secrets-manager-credentials-provider-plugin] and I am adding new type of credentials.

      The principle is simple: add a tag in AWS with the secret type and store a JSON as value. I am looking for some feedback of the implementation. Right now only happy paths are implemented but I would like to know if I am following the proper path.

       

      Thanks in advance!

        Attachments

          Activity

          Hide
          chriskilding Chris Kilding added a comment -

          I’ve now completed a first draft implementation of multiple credential types support over at https://github.com/jenkinsci/aws-secrets-manager-credentials-provider-plugin/pull/8

          Your questions and comments are welcome

          Show
          chriskilding Chris Kilding added a comment - I’ve now completed a first draft implementation of multiple credential types support over at https://github.com/jenkinsci/aws-secrets-manager-credentials-provider-plugin/pull/8 Your questions and comments are welcome
          Hide
          ntalbot Nat Talbot added a comment - - edited

          Hi Chris,

          Thanks for doing this implementation! I started using the plugin with AWS Secrets Manager this week it's a feature that is definitely really really helpful. I'm going to try to manually install the plugin from the built .hpi and test the new features, can provide feedback on the PR if there's anything worth mentioning.

          Show
          ntalbot Nat Talbot added a comment - - edited Hi Chris, Thanks for doing this implementation! I started using the plugin with AWS Secrets Manager this week it's a feature that is definitely really really helpful. I'm going to try to manually install the plugin from the built .hpi and test the new features, can provide feedback on the PR if there's anything worth mentioning.
          Hide
          chriskilding Chris Kilding added a comment - - edited

          Enrique Fernández-Polo I have found a way to add support for this feature in this GitHub PR . Since you originally requested this feature I would be interested to hear your feedback and whether it works for your company.

          We have some Jenkins deployments coming up at work soon, so if I don’t hear anything by the 22nd November I will merge that PR to master. And then publish a Release Candidate artifact to Jenkins Experimentals (this will contain the final functionality, and any changes after will only be bug fixes).

          Show
          chriskilding Chris Kilding added a comment - - edited Enrique Fernández-Polo I have found a way to add support for this feature in this GitHub PR . Since you originally requested this feature I would be interested to hear your feedback and whether it works for your company. We have some Jenkins deployments coming up at work soon, so if I don’t hear anything by the 22nd November I will merge that PR to master. And then publish a Release Candidate artifact to Jenkins Experimentals (this will contain the final functionality, and any changes after will only be bug fixes).
          Hide
          stradenko C added a comment -

          Chris Kilding - I'll open another issue on it, but curious what you think about using parameter store as a backend.  Do you think that having that functionality in this plugin (so the plugin can scan either secrets manager, or parameter store) is a good idea?

          Show
          stradenko C added a comment - Chris Kilding - I'll open another issue on it, but curious what you think about using parameter store as a backend.  Do you think that having that functionality in this plugin (so the plugin can scan either secrets manager, or parameter store) is a good idea?
          Hide
          chriskilding Chris Kilding added a comment -

          I don’t have an intuition for that off the top of my head, but it’s certainly worth a discussion as I know of a couple of projects in our place that put their secrets in parameter store.

          Open a ticket and we’ll discuss

          Show
          chriskilding Chris Kilding added a comment - I don’t have an intuition for that off the top of my head, but it’s certainly worth a discussion as I know of a couple of projects in our place that put their secrets in parameter store. Open a ticket and we’ll discuss

            People

            Assignee:
            chriskilding Chris Kilding
            Reporter:
            quaiks Enrique Fernández-Polo
            Votes:
            2 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: