Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-58362

CommandLauncher2Test.requireApproval failure due to two copies of SystemCommandLanguage

    XMLWordPrintable

Details

    • 2.185

    Description

      JENKINS-57528 included a bump to the detached script-security which should have been paired with a bump to the detached command-launcher. To reproduce, run

      mvn -f command-launcher-plugin test -Djenkins.version=2.176.1 -Dtest=CommandLauncher2Test\#requireApproval
      

      which passes; now bump its parent to 3.47 and include

      -Djenkins.version=2.176.2-rc28314.ce9ac38e8574 -Pconsume-incrementals
      

      which pulls in this backport by olivergondza and you will get a failure:

      java.lang.AssertionError: expected:<org.jenkinsci.plugins.scriptsecurity.scripts.languages.SystemCommandLanguage@...> but was:<org.jenkinsci.plugins.command_launcher.SystemCommandLanguage@...>
      	at org.junit.Assert.fail(Assert.java:88)
      	at org.junit.Assert.failNotEquals(Assert.java:834)
      	at org.junit.Assert.assertEquals(Assert.java:118)
      	at org.junit.Assert.assertEquals(Assert.java:144)
      	at hudson.slaves.CommandLauncher2Test$1.evaluate(CommandLauncher2Test.java:119)
      

      Attachments

        Issue Links

          Activity

            People

              jglick Jesse Glick
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: