Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-590

bad diff link for viewcvs

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: cvs-plugin
    • Labels:
      None
    • Environment:
      Platform: All, OS: All
    • Similar Issues:

      Description

      my projects has files in branches so most of the files live in Attic
      the link to file diff is not working from hudson:

      https://myserver/cgi-bin/viewcvs.cgi/project/hibernate/
      HibernateClientDao.java.diff?r1=1.1.4.11&r2=1.1.4.11.2.1

      working link:

      https://myserver/cgi-bin/viewcvs.cgi/project/hibernate/Attic/
      HibernateClientDao.java?r1=1.1.4.11&r2=1.1.4.11.2.1

      two notable differences:
      no suffix ".diff" and additional path "Attic"

      suffix ".diff" is optional in ViewCVS
      if you don;t add ".diff" it knows how to redirect to Attic.

        Attachments

          Activity

          Hide
          pukomuko pukomuko added a comment -

          i have ViewCVS 1.0-dev

          Show
          pukomuko pukomuko added a comment - i have ViewCVS 1.0-dev
          Hide
          kohsuke Kohsuke Kawaguchi added a comment -

          According to
          http://viewvc.tigris.org/source/browse/*checkout*/viewvc/trunk/docs/url-reference.html#compat-attic,
          it seems like always having 'Attic' in the link should let us resolve to the
          right resource.

          That is, if the file is indeed in the attic, the path would resolve, and if the
          file is not in the attic, the rewrite rule kicks in and redirects the user to
          the right page.

          So I made a change accordingly.

          If you can test the snapshot bulid, that would be great.

          Show
          kohsuke Kohsuke Kawaguchi added a comment - According to http://viewvc.tigris.org/source/browse/*checkout*/viewvc/trunk/docs/url-reference.html#compat-attic , it seems like always having 'Attic' in the link should let us resolve to the right resource. That is, if the file is indeed in the attic, the path would resolve, and if the file is not in the attic, the rewrite rule kicks in and redirects the user to the right page. So I made a change accordingly. If you can test the snapshot bulid, that would be great.
          Hide
          pukomuko pukomuko added a comment -

          in 1.0-dev it is working backwards:

          here is source code comment:

          1. If the path doesn't exist, but we have CVS repository, and the
          2. path doesn't already include an 'Attic' component, see if maybe
          3. the thing lives in the Attic.

          so they add "Attic", but do not try to remove it.

          i cannot migrate from 1.0-dev because we are stuck with python 2.3

          Show
          pukomuko pukomuko added a comment - in 1.0-dev it is working backwards: here is source code comment: If the path doesn't exist, but we have CVS repository, and the path doesn't already include an 'Attic' component, see if maybe the thing lives in the Attic. so they add "Attic", but do not try to remove it. i cannot migrate from 1.0-dev because we are stuck with python 2.3
          Hide
          kohsuke Kohsuke Kawaguchi added a comment -

          OK, then I have to make a choice. Either to support 1.0 (and presumably future
          versions as well) or 1.0-dev (which is a snapshot toward 1.0, right?), and then
          I have to choose 1.0.

          What I'd suggest is for you to write a plugin for ViewCVS 1.0-dev.

          Show
          kohsuke Kohsuke Kawaguchi added a comment - OK, then I have to make a choice. Either to support 1.0 (and presumably future versions as well) or 1.0-dev (which is a snapshot toward 1.0, right?), and then I have to choose 1.0. What I'd suggest is for you to write a plugin for ViewCVS 1.0-dev.
          Hide
          kohsuke Kohsuke Kawaguchi added a comment -

          I had to roll back the change to add "Attic" in 1.111 since that was reported as
          a problem in issue #601. So we are back to square 1.

          Maybe we should contact ViewVC guys to figure out what to do.

          Show
          kohsuke Kohsuke Kawaguchi added a comment - I had to roll back the change to add "Attic" in 1.111 since that was reported as a problem in issue #601. So we are back to square 1. Maybe we should contact ViewVC guys to figure out what to do.
          Hide
          pukomuko pukomuko added a comment -

          CLOSE this bug.
          We upgraded to latest ViewVC and everything works ok.

          Show
          pukomuko pukomuko added a comment - CLOSE this bug. We upgraded to latest ViewVC and everything works ok.
          Hide
          kohsuke Kohsuke Kawaguchi added a comment -

          Closed as requested.

          Show
          kohsuke Kohsuke Kawaguchi added a comment - Closed as requested.

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            pukomuko pukomuko
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: