• Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • p4-plugin
    • None
    • Jenkins ver. 2.150.2
      Plugin ver. 1.10.3

      When a READONLY client is synced with the "Auto cleanup and sync" option, the reconcile throws an innocuous "Client of type 'readonly' cannot modify files." error. In 1.10, this error is ignored. In 1.10.3, this error causes the build to fail.

      This may be a consequence of a modification to src/main/java/org/jenkinsci/plugins/p4/client/ClientHelper.java in Change 25759, which added an exception when a reconcile fails. Unfortunately, in the above scenario, reconcile shouldn't even be called, so the fact that it fails should be ignored.

          [JENKINS-59207] READONLY autoclean sync fails on reconcile

          Issue introduced in 1.10.1, so does seem like 25759 is likely

          Doug Whitfield added a comment - Issue introduced in 1.10.1, so does seem like 25759 is likely

          Joel Brown added a comment -

          The fact the reconcile failure was ignored in an earlier release is a bug - the error should have been surfaced.   IMO, we fixed it the change you noted.  

          auto cleanup and sync should run "reconcile -w -f" to make the workspace consistent with the last sync.   

          Joel Brown added a comment - The fact the reconcile failure was ignored in an earlier release is a bug - the error should have been surfaced.   IMO, we fixed it the change you noted.   auto cleanup and sync should run "reconcile -w -f" to make the workspace consistent with the last sync.   

            Unassigned Unassigned
            feelingmimsy Dave Miller
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated: