Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5944

Console output gets additional linebreaks with 1.351 (were not there in 1.349)

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • None
    • Hudson 1.351
      Firefox 3.6

      I just upgraded from Hudson 1.349 to 1.351 and when now looking at the console output of a build, I get additional empty lines shown where before this was not the case.

      I attached a screenshot showing this and I marked the empty lines.

      This shows up for both: New builds and old build, thus I think there was a change in the internal rendering/formatting engine in Hudson causing this effect.

      Is it possible to get the "old" (i.e. no extra empty lines) formatting back?

          [JENKINS-5944] Console output gets additional linebreaks with 1.351 (were not there in 1.349)

          Alan Harder added a comment -

          This is likely related to the console annotation support recently added. What OS is your Hudson server? I don't see this on Mac OS X.. but I do see this comment in hudson.console.LineTransformationOutputStream: "TODO: Mac is supposed to be CR-only. This class needs to handle that." Maybe lack of Mac support in this class is saving me from this bug? Just a guess..

          Alan Harder added a comment - This is likely related to the console annotation support recently added. What OS is your Hudson server? I don't see this on Mac OS X.. but I do see this comment in hudson.console.LineTransformationOutputStream: "TODO: Mac is supposed to be CR-only. This class needs to handle that." Maybe lack of Mac support in this class is saving me from this bug? Just a guess..

          Alan Harder added a comment -

          Do you see this effect in "view as plain text" too, or just in the html view of the console?

          Alan Harder added a comment - Do you see this effect in "view as plain text" too, or just in the html view of the console?

          illenseer added a comment -

          I just opened the Hudson website with the Internet Explorer 8 for testing and there the extra empty lines do not show up... - Strange.

          I have no special things set in my Firefox and I also did not change the Firefox (i.e. same version where it was working before and now).

          illenseer added a comment - I just opened the Hudson website with the Internet Explorer 8 for testing and there the extra empty lines do not show up... - Strange. I have no special things set in my Firefox and I also did not change the Firefox (i.e. same version where it was working before and now).

          illenseer added a comment -

          @mindless:

          • Server-OS is Windows XP SP3
          • I only see this effect in the HTML view of the console
            if I switch to "view as plain text" the additional lines are gone

          illenseer added a comment - @mindless: Server-OS is Windows XP SP3 I only see this effect in the HTML view of the console if I switch to "view as plain text" the additional lines are gone

          Alan Harder added a comment -

          I found a bug where Hudson uses <br> and   in the console output if nothing gets annotated, when it should leave newlines and spaces alone since this is inside a <pre> element. This will be fixed in 1.352, and I hope it will resolve this issue for you.

          Alan Harder added a comment - I found a bug where Hudson uses <br> and   in the console output if nothing gets annotated, when it should leave newlines and spaces alone since this is inside a <pre> element. This will be fixed in 1.352, and I hope it will resolve this issue for you.

          Code changed in hudson
          User: : mindless
          Path:
          trunk/hudson/main/core/src/main/java/hudson/MarkupText.java
          trunk/hudson/main/core/src/test/java/hudson/MarkupTextTest.java
          http://jenkins-ci.org/commit/28737
          Log:
          JENKINS-5941 JENKINS-5944 MarkupText.toString(boolean) was ignoring the
          preEscape parameter when no markup tags were added.

          SCM/JIRA link daemon added a comment - Code changed in hudson User: : mindless Path: trunk/hudson/main/core/src/main/java/hudson/MarkupText.java trunk/hudson/main/core/src/test/java/hudson/MarkupTextTest.java http://jenkins-ci.org/commit/28737 Log: JENKINS-5941 JENKINS-5944 MarkupText.toString(boolean) was ignoring the preEscape parameter when no markup tags were added.

          illenseer added a comment -

          Thanks for having a look and a possible fix ready in such short time!
          I'll definitely test 1.352 and report here.

          illenseer added a comment - Thanks for having a look and a possible fix ready in such short time! I'll definitely test 1.352 and report here.

          Alan Harder added a comment -

          1.352 is out.. let us know what you find.

          Alan Harder added a comment - 1.352 is out.. let us know what you find.

          illenseer added a comment -

          Thanks for fixing. - Looks fine and as expected for me now again in 1.352

          illenseer added a comment - Thanks for fixing. - Looks fine and as expected for me now again in 1.352

            mindless Alan Harder
            illenseer illenseer
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: